From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 0/2] Add DT support for i2s
Date: Sun, 9 Dec 2012 16:26:08 +0900 [thread overview]
Message-ID: <20121209072607.GD6511@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAAgF-BenOdFJK2LMot73_B=wHOFgD2sq8x-Ou=1CvpkiJpmeQQ@mail.gmail.com>
On Sat, Dec 08, 2012 at 10:07:54AM +0530, Padma Venkat wrote:
> Samsung i2s driver registers the platform device twice one for the
> samsung-i2s.0,1 or 2 and two for samsung-i2s.4(which actually doesn't
> represent any H/W peripheral). The max number of I2S blocks on any
> Samsung SoC are 3, the secondary device registration starts with
> device number 4.The second time registration is for the secondary fifo
> interface of a CPU dai if any exists.
> With DT support the device number in the driver is always -1, I used
> alias id for the above purpose.
So, the thing here is that while the numbers were totally OK for
platform device use they really don't fit into DT at all well. I think
the thing here is to either have a node for the second CPU side DAI or
to have a single DT link automatically expanded into two DAI links. I
think the second option is much better - there's only one link on the
board, it just happens to get expanded into two the way things are
currently implemented in ASoC.
This stuff probably also ought to be moved over to soc-pcm as well by
the way.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121209/68c7a3a4/attachment.sig>
next prev parent reply other threads:[~2012-12-09 7:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 10:47 [PATCH V4 0/2] Add DT support for i2s Padmavathi Venna
2012-11-28 10:47 ` [PATCH V4 1/2] ASoC: Samsung: Get I2S src_clk from clock alias id Padmavathi Venna
2012-11-28 19:18 ` Mark Brown
2012-11-28 10:47 ` [PATCH V4 2/2] ASoC: SAMSUNG: Add DT support for i2s Padmavathi Venna
2012-12-06 4:01 ` [PATCH V4 0/2] " Padma Venkat
2012-12-06 4:11 ` Mark Brown
2012-12-07 13:51 ` Grant Likely
2012-12-08 4:37 ` Padma Venkat
2012-12-09 7:26 ` Mark Brown [this message]
2012-12-10 11:00 ` Padma Venkat
2012-12-10 14:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209072607.GD6511@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).