From: w@1wt.eu (Willy Tarreau)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: kirkwood: convert Guruplug Server Plus to use the device tree
Date: Sun, 9 Dec 2012 23:37:53 +0100 [thread overview]
Message-ID: <20121209223753.GE28052@1wt.eu> (raw)
In-Reply-To: <20121209220245.GF21694@titan.lakedaemon.net>
On Sun, Dec 09, 2012 at 05:02:45PM -0500, Jason Cooper wrote:
> > + model = "Globalscale Technologies Guruplug Server Plus";
> > + compatible = "globalscale,guruplug-server-plug", "globalscale,guruplug", "marvell,kirkwood-88f6281", "marvell,kirkwood";
>
> One small typo, should be "...server-plus". If there are no other
> comments over the next few days, I'll tweak it when I pull it in.
I'm amazed, because you did exactly the same one in your initial review
last week and I noticed it back then. Then I did this one without copy-
pasting yours! It seems like our brain is too much attracted by those
similarly looking letters. Sorry for this one.
Thanks,
Willy
next prev parent reply other threads:[~2012-12-09 22:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 15:51 [PATCH] ARM: kirkwood: convert Guruplug to use the device tree Willy Tarreau
2012-12-02 23:09 ` Jason Cooper
2012-12-02 23:22 ` Willy Tarreau
2012-12-02 23:41 ` Jason Cooper
2012-12-02 23:48 ` Willy Tarreau
2012-12-03 0:09 ` Jason Cooper
2012-12-09 18:40 ` [PATCH v2] ARM: kirkwood: convert Guruplug Server Plus " Willy Tarreau
2012-12-09 22:02 ` Jason Cooper
2012-12-09 22:37 ` Willy Tarreau [this message]
2012-12-09 23:57 ` Jason Cooper
2013-01-07 17:48 ` Jason Cooper
2013-01-07 18:08 ` Willy Tarreau
2013-01-07 18:17 ` Jason Cooper
2013-01-07 18:20 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209223753.GE28052@1wt.eu \
--to=w@1wt.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).