From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: decompressor: include CONFIG_DEBUG_LL_INCLUDE rather than mach/debug-macro.S
Date: Mon, 10 Dec 2012 14:02:50 +0000 [thread overview]
Message-ID: <20121210140250.GL14363@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20121210015916.GA30766@S2101-09.ap.freescale.net>
On Mon, Dec 10, 2012 at 09:59:18AM +0800, Shawn Guo wrote:
> On Mon, Dec 10, 2012 at 09:49:28AM +0800, Shawn Guo wrote:
> > Commit 91a9fec (ARM: move debug macros to common location) moves
> > arch/arm/kernel/debug.S and arch/arm/kernel/head.S to
> > CONFIG_DEBUG_LL_INCLUDE, but leaves arch/arm/boot/compressed/head.S
> > still with mach/debug-macro.S. This causes the following build error
> > on platforms that moved to new DEBUG_LL inclusion mechanism, when
> > arch/arm/boot/compressed/head.S is compiled with DEBUG turned on.
> >
> > AS arch/arm/boot/compressed/head.o
> > arch/arm/boot/compressed/head.S:49:30: fatal error: mach/debug-macro.S: No such file or directory
> > compilation terminated.
> >
> > Fix the problem by replacing mach/debug-macro.S inclusion with
> > CONFIG_DEBUG_LL_INCLUDE one.
> >
> > Reported-by: Steev Klimaszewski <steev@genesi-usa.com>
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Cc: stable at vger.kernel.org
>
> I copied stable with assuming that the patch is not going to catch
> on the final 3.7 release. If it's not the case or maintainer does not
> think it's a stable material at all, we can just drop the tag.
That worries me a bit because I can see this ending up getting applied to
multiple stable kernel trees, even those without CONFIG_DEBUG_LL_INCLUDE.
So, let's have it in the patch system without the stable tag.
Thanks.
next prev parent reply other threads:[~2012-12-10 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 1:49 [PATCH] ARM: decompressor: include CONFIG_DEBUG_LL_INCLUDE rather than mach/debug-macro.S Shawn Guo
2012-12-10 1:59 ` Shawn Guo
2012-12-10 14:02 ` Russell King - ARM Linux [this message]
2012-12-10 14:46 ` Jonathan Nieder
2012-12-10 13:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210140250.GL14363@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).