From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] mtd: devices: elm: Add support for ELM error correction
Date: Tue, 11 Dec 2012 09:03:56 +0000 [thread overview]
Message-ID: <20121211090356.8D3D93E076D@localhost> (raw)
In-Reply-To: <1354189595-12784-3-git-send-email-avinashphilip@ti.com>
On Thu, 29 Nov 2012 17:16:33 +0530, "Philip, Avinash" <avinashphilip@ti.com> wrote:
> The ELM hardware module can be used to speedup BCH 4/8/16 ECC scheme
> error correction.
> For now only 4 & 8 bit support is added
>
> Signed-off-by: Philip, Avinash <avinashphilip@ti.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Rob Landley <rob@landley.net>
> ---
> Changes since v2:
> - Remove __devinit & __devexit annotations
>
> Changes since v1:
> - Change build attribute to CONFIG_MTD_NAND_OMAP_BCH
> - Reduced indentation using by passing elm_info , offset
> to elm_read & elm_write
> - Removed syndrome manipulation functions.
>
> :000000 100644 0000000... b88ee83... A Documentation/devicetree/bindings/mtd/elm.txt
> :100644 100644 395733a... 369a194... M drivers/mtd/devices/Makefile
> :000000 100644 0000000... d2667f3... A drivers/mtd/devices/elm.c
> :000000 100644 0000000... d4fce31... A include/linux/platform_data/elm.h
> Documentation/devicetree/bindings/mtd/elm.txt | 17 +
> drivers/mtd/devices/Makefile | 4 +-
> drivers/mtd/devices/elm.c | 418 +++++++++++++++++++++++++
> include/linux/platform_data/elm.h | 54 ++++
> 4 files changed, 493 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
> new file mode 100644
> index 0000000..b88ee83
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/elm.txt
> @@ -0,0 +1,17 @@
> +Error location module
> +
> +Required properties:
> +- compatible: Must be "ti,elm"
Compatible string is too generic. Need to specify a specific SoC here.
ie: "ti,omap3430-elm"
Otherwise the binding looks fine. I haven't reviewed the code though.
g.
next prev parent reply other threads:[~2012-12-11 9:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 11:46 [PATCH v3 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc Philip, Avinash
2012-11-29 11:46 ` [PATCH v3 1/3] mtd: nand: omap2: Update nerrors using ecc.strength Philip, Avinash
2012-12-05 12:03 ` Sekhar Nori
2012-12-05 12:43 ` Philip, Avinash
2012-12-07 10:40 ` Sekhar Nori
2012-12-10 6:44 ` Philip, Avinash
2012-11-29 11:46 ` [PATCH v3 2/3] mtd: devices: elm: Add support for ELM error correction Philip, Avinash
2012-12-07 10:37 ` Sekhar Nori
2012-12-10 6:43 ` Philip, Avinash
2012-12-12 11:15 ` Sekhar Nori
2012-12-11 9:03 ` Grant Likely [this message]
2012-12-11 12:55 ` Philip, Avinash
2012-11-29 11:46 ` [PATCH v3 3/3] mtd: nand: omap2: Support for hardware BCH " Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211090356.8D3D93E076D@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).