From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses
Date: Thu, 13 Dec 2012 09:33:50 +0900 [thread overview]
Message-ID: <20121213003350.GG13343@verge.net.au> (raw)
In-Reply-To: <OF613746CC.4E3EB4D0-ON80257AD2.0038052F-80257AD2.00381232@eu.necel.com>
On Wed, Dec 12, 2012 at 10:12:27AM +0000, phil.edworthy at renesas.com wrote:
> Hi Simon, Laurent,
>
> (resend as plain text)
>
> > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > To: Phil Edworthy <phil.edworthy@renesas.com>,
> > Cc: Simon <horms@verge.net.au>, linux-sh at vger.kernel.org, linux-arm-
> > kernel at lists.infradead.org, Magnus <magnus.damm@gmail.com>, Laurent
> > Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Date: 11/12/2012 11:39
> > Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg
> addresses
> >
> > On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:
> > > The INDTx register addresses were wrong.
> > >
> > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> >
> > You can add
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Please scrap this patch. I just found out that it screws up the GPIO
> outputs. The current code assumes the same register is used for both input
> and output, which is not the case. It needs a bit of work to fix this.
Thanks, I have marked v1 and v2 as Rejected in patchwork.
prev parent reply other threads:[~2012-12-13 0:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 9:48 [PATCH] ARM: shmobile: r8a7779: Fix GPIO input reg addresses Phil Edworthy
2012-12-11 10:56 ` Laurent Pinchart
2012-12-11 11:34 ` [PATCH v2] " Phil Edworthy
2012-12-11 11:40 ` Laurent Pinchart
2012-12-12 9:57 ` phil.edworthy at renesas.com
2012-12-12 10:12 ` phil.edworthy at renesas.com
2012-12-13 0:33 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213003350.GG13343@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).