* [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event
@ 2012-12-13 5:27 Vipul Kumar Samar
2012-12-13 6:34 ` Viresh Kumar
2012-12-13 9:10 ` Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Vipul Kumar Samar @ 2012-12-13 5:27 UTC (permalink / raw)
To: linux-arm-kernel
stmpe touchscreen supports BTN_TOUCH event but doesn't report it. Add
BTN_TOUCH reporting capability to the stmpe touchscreen driver.
Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com>
---
drivers/input/touchscreen/stmpe-ts.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 076442a..c3399a1 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -121,6 +121,7 @@ static void stmpe_work(struct work_struct *work)
__stmpe_reset_fifo(ts->stmpe);
input_report_abs(ts->idev, ABS_PRESSURE, 0);
+ input_report_key(ts->idev, BTN_TOUCH, 0);
input_sync(ts->idev);
}
@@ -154,6 +155,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
input_report_abs(ts->idev, ABS_X, x);
input_report_abs(ts->idev, ABS_Y, y);
input_report_abs(ts->idev, ABS_PRESSURE, z);
+ input_report_key(ts->idev, BTN_TOUCH, 1);
input_sync(ts->idev);
/* flush the FIFO after we have read out our values. */
--
1.7.2.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event
2012-12-13 5:27 [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event Vipul Kumar Samar
@ 2012-12-13 6:34 ` Viresh Kumar
2012-12-13 9:10 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2012-12-13 6:34 UTC (permalink / raw)
To: linux-arm-kernel
On 13 December 2012 10:57, Vipul Kumar Samar <vipulkumar.samar@st.com> wrote:
> stmpe touchscreen supports BTN_TOUCH event but doesn't report it. Add
> BTN_TOUCH reporting capability to the stmpe touchscreen driver.
>
> Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com>
> ---
> drivers/input/touchscreen/stmpe-ts.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 076442a..c3399a1 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -121,6 +121,7 @@ static void stmpe_work(struct work_struct *work)
> __stmpe_reset_fifo(ts->stmpe);
>
> input_report_abs(ts->idev, ABS_PRESSURE, 0);
> + input_report_key(ts->idev, BTN_TOUCH, 0);
> input_sync(ts->idev);
> }
>
> @@ -154,6 +155,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
> input_report_abs(ts->idev, ABS_X, x);
> input_report_abs(ts->idev, ABS_Y, y);
> input_report_abs(ts->idev, ABS_PRESSURE, z);
> + input_report_key(ts->idev, BTN_TOUCH, 1);
> input_sync(ts->idev);
>
> /* flush the FIFO after we have read out our values. */
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event
2012-12-13 5:27 [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event Vipul Kumar Samar
2012-12-13 6:34 ` Viresh Kumar
@ 2012-12-13 9:10 ` Lee Jones
2012-12-17 7:11 ` Dmitry Torokhov
1 sibling, 1 reply; 4+ messages in thread
From: Lee Jones @ 2012-12-13 9:10 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 13 Dec 2012, Vipul Kumar Samar wrote:
> stmpe touchscreen supports BTN_TOUCH event but doesn't report it. Add
> BTN_TOUCH reporting capability to the stmpe touchscreen driver.
>
> Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com>
> ---
> drivers/input/touchscreen/stmpe-ts.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index 076442a..c3399a1 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -121,6 +121,7 @@ static void stmpe_work(struct work_struct *work)
> __stmpe_reset_fifo(ts->stmpe);
>
> input_report_abs(ts->idev, ABS_PRESSURE, 0);
> + input_report_key(ts->idev, BTN_TOUCH, 0);
> input_sync(ts->idev);
> }
>
> @@ -154,6 +155,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
> input_report_abs(ts->idev, ABS_X, x);
> input_report_abs(ts->idev, ABS_Y, y);
> input_report_abs(ts->idev, ABS_PRESSURE, z);
> + input_report_key(ts->idev, BTN_TOUCH, 1);
> input_sync(ts->idev);
>
> /* flush the FIFO after we have read out our values. */
> --
> 1.7.2.2
So long as it's tested/working, the code looks fine so:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event
2012-12-13 9:10 ` Lee Jones
@ 2012-12-17 7:11 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2012-12-17 7:11 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 13, 2012 at 09:10:04AM +0000, Lee Jones wrote:
> On Thu, 13 Dec 2012, Vipul Kumar Samar wrote:
>
> > stmpe touchscreen supports BTN_TOUCH event but doesn't report it. Add
> > BTN_TOUCH reporting capability to the stmpe touchscreen driver.
> >
> > Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > ---
> > drivers/input/touchscreen/stmpe-ts.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> > index 076442a..c3399a1 100644
> > --- a/drivers/input/touchscreen/stmpe-ts.c
> > +++ b/drivers/input/touchscreen/stmpe-ts.c
> > @@ -121,6 +121,7 @@ static void stmpe_work(struct work_struct *work)
> > __stmpe_reset_fifo(ts->stmpe);
> >
> > input_report_abs(ts->idev, ABS_PRESSURE, 0);
> > + input_report_key(ts->idev, BTN_TOUCH, 0);
> > input_sync(ts->idev);
> > }
> >
> > @@ -154,6 +155,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
> > input_report_abs(ts->idev, ABS_X, x);
> > input_report_abs(ts->idev, ABS_Y, y);
> > input_report_abs(ts->idev, ABS_PRESSURE, z);
> > + input_report_key(ts->idev, BTN_TOUCH, 1);
> > input_sync(ts->idev);
> >
> > /* flush the FIFO after we have read out our values. */
> > --
> > 1.7.2.2
>
> So long as it's tested/working, the code looks fine so:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-17 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-13 5:27 [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event Vipul Kumar Samar
2012-12-13 6:34 ` Viresh Kumar
2012-12-13 9:10 ` Lee Jones
2012-12-17 7:11 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).