From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver
Date: Fri, 14 Dec 2012 15:10:03 +0000 [thread overview]
Message-ID: <20121214151002.GK14363@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1355495429-12510-3-git-send-email-ulf.hansson@stericsson.com>
On Fri, Dec 14, 2012 at 03:30:29PM +0100, Ulf Hansson wrote:
> From: Lee Jones <lee.jones@linaro.org>
>
> There are currently two instances of the ios_handler being used.
> Both of which mearly toy with some regulator settings. Now there
> is a GPIO regulator API, we can use that instead, and lessen the
> per platform burden. By doing this, we also become more Device
> Tree compatible.
Err, why is this needed? What's wrong with using the 'vmmc' for this?
>From what I read in the mmc core, vmmc handling via mmc_regulator_set_ocr()
can cope with GPIO-based regulators, and if you have a single GPIO signal
then you have a single supply (it's either on or off). So what's wrong
with using the existing regulator hooks for this which are already there?
next prev parent reply other threads:[~2012-12-14 15:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 14:30 [PATCH 0/2] mmc: mmci: Update regulator support Ulf Hansson
2012-12-14 14:30 ` [PATCH 1/2] mmc: mmci: Convert to use mmc_regulator_get_supply Ulf Hansson
2012-12-14 14:30 ` [PATCH V2 2/2] mmc: mmci: Move ios_handler functionality into the driver Ulf Hansson
2012-12-14 15:10 ` Russell King - ARM Linux [this message]
2012-12-14 15:52 ` Ulf Hansson
2012-12-14 16:33 ` Lee Jones
2013-01-22 9:00 ` Lee Jones
2013-01-22 9:53 ` Linus Walleij
2013-01-22 10:06 ` Russell King - ARM Linux
2013-01-22 10:11 ` Linus Walleij
2013-01-22 10:20 ` Lee Jones
2013-01-22 10:37 ` Russell King - ARM Linux
2013-01-22 10:56 ` Lee Jones
2013-01-23 10:13 ` Lee Jones
2013-01-23 10:17 ` Russell King - ARM Linux
2013-01-23 11:18 ` Lee Jones
2013-01-24 12:55 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214151002.GK14363@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).