* [PATCH 6/8] arch/arm/mach-omap2/dpll3xxx.c: drop if around WARN_ON
[not found] <1351974625-10282-1-git-send-email-Julia.Lawall@lip6.fr>
@ 2012-11-03 20:30 ` Julia Lawall
2012-12-14 18:53 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2012-11-03 20:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Just use WARN_ON rather than an if containing only WARN_ON(1).
A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e;
@@
- if (e) WARN_ON(1);
+ WARN_ON(e);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/arm/mach-omap2/dpll3xxx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
index eacf51f..ed855b0 100644
--- a/arch/arm/mach-omap2/dpll3xxx.c
+++ b/arch/arm/mach-omap2/dpll3xxx.c
@@ -478,8 +478,7 @@ int omap3_noncore_dpll_set_rate(struct clk *clk, unsigned long rate)
if (!soc_is_am33xx() && !cpu_is_omap44xx() && !cpu_is_omap3630()) {
freqsel = _omap3_dpll_compute_freqsel(clk,
dd->last_rounded_n);
- if (!freqsel)
- WARN_ON(1);
+ WARN_ON(!freqsel);
}
pr_debug("clock: %s: set rate: locking rate to %lu.\n",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 6/8] arch/arm/mach-omap2/dpll3xxx.c: drop if around WARN_ON
2012-11-03 20:30 ` [PATCH 6/8] arch/arm/mach-omap2/dpll3xxx.c: drop if around WARN_ON Julia Lawall
@ 2012-12-14 18:53 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-12-14 18:53 UTC (permalink / raw)
To: linux-arm-kernel
* Julia Lawall <Julia.Lawall@lip6.fr> [121103 13:32]:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Just use WARN_ON rather than an if containing only WARN_ON(1).
Thanks applying this one into omap-for-v3.8/fixes-for-merge-window.
Regards,
Tony
> A simplified version of the semantic patch that makes this transformation
> is as follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e;
> @@
> - if (e) WARN_ON(1);
> + WARN_ON(e);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> arch/arm/mach-omap2/dpll3xxx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c
> index eacf51f..ed855b0 100644
> --- a/arch/arm/mach-omap2/dpll3xxx.c
> +++ b/arch/arm/mach-omap2/dpll3xxx.c
> @@ -478,8 +478,7 @@ int omap3_noncore_dpll_set_rate(struct clk *clk, unsigned long rate)
> if (!soc_is_am33xx() && !cpu_is_omap44xx() && !cpu_is_omap3630()) {
> freqsel = _omap3_dpll_compute_freqsel(clk,
> dd->last_rounded_n);
> - if (!freqsel)
> - WARN_ON(1);
> + WARN_ON(!freqsel);
> }
>
> pr_debug("clock: %s: set rate: locking rate to %lu.\n",
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-14 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1351974625-10282-1-git-send-email-Julia.Lawall@lip6.fr>
2012-11-03 20:30 ` [PATCH 6/8] arch/arm/mach-omap2/dpll3xxx.c: drop if around WARN_ON Julia Lawall
2012-12-14 18:53 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).