linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: export __clk_get_name for re-use in imx-ipu-v3 and others
Date: Mon, 17 Dec 2012 09:59:52 +0100	[thread overview]
Message-ID: <20121217085952.GH26326@pengutronix.de> (raw)
In-Reply-To: <1355400745-7320-1-git-send-email-ndevos@redhat.com>

On Thu, Dec 13, 2012 at 01:12:25PM +0100, Niels de Vos wrote:
> This fixes the following error when building for arm-imx:
> > ERROR: "__clk_get_name" [drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> 
> There are valid usecases to get the name of a clock, be it for debugging
> purposes or to register a children of a clock like done in this IPU driver.
> Therefore exporting __clk_get_name() and make it available for others makes
> sense.

Gnerally I think the name of a clock shouldn't be a secret, so:

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

> 
> Reported-by: Peter Robinson <pbrobinson@gmail.com>
> CC: Sascha Hauer <s.hauer@pengutronix.de>
> CC: Mike Turquette <mturquette@linaro.org>
> Signed-off-by: Niels de Vos <ndevos@redhat.com>
> ---
>  drivers/clk/clk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 251e45d..fbe0f3a 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -259,10 +259,11 @@ late_initcall(clk_disable_unused);
>  
>  /***    helper functions   ***/
>  
> -inline const char *__clk_get_name(struct clk *clk)
> +const char *__clk_get_name(struct clk *clk)
>  {
>  	return !clk ? NULL : clk->name;
>  }
> +EXPORT_SYMBOL_GPL(__clk_get_name);
>  
>  inline struct clk_hw *__clk_get_hw(struct clk *clk)
>  {
> -- 
> 1.7.11.7
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-12-17  8:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-13 12:12 [PATCH] clk: export __clk_get_name for re-use in imx-ipu-v3 and others Niels de Vos
2012-12-17  8:59 ` Sascha Hauer [this message]
2013-01-12  2:40   ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121217085952.GH26326@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).