linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add apf51 basic support
Date: Wed, 19 Dec 2012 21:39:36 +0100	[thread overview]
Message-ID: <20121219203936.GG26326@pengutronix.de> (raw)
In-Reply-To: <1355694591-7084-1-git-send-email-laurent.cans@gmail.com>

On Sun, Dec 16, 2012 at 10:49:51PM +0100, Laurent Cans wrote:
> Signed-off-by: Laurent Cans <laurent.cans@gmail.com>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
> ---
> +	clocks {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ckih1 {
> +			compatible = "fsl,imx-ckih1", "fixed-clock";
> +			clock-frequency = <0>;
> +		};
> +
> +		osc {
> +			compatible = "fsl,imx-osc", "fixed-clock";
> +			clock-frequency = <33554432>;
> +		};

These compatible properties shouldn't be necessary, right?

> +	};
> +	soc {
> +		aips at 70000000 { /* aips-1 */
> +			spba at 70000000 {
> +				uart3: serial at 7000c000 {
> +					pinctrl-names = "default";
> +					pinctrl-0 = <&pinctrl_uart3_2>;
> +					status = "okay";
> +				};
> +			};
> +		};

This (and the other nodes) can more eaasily be written as:

&uart3 {
	...
};

see arch/arm/boot/dts/omap5-evm.dts for a good example.

This has the advantage that you don't have to resemble the SoC layout
in your board file.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-12-19 20:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-16 21:49 [PATCH] Add apf51 basic support Laurent Cans
2012-12-19 20:39 ` Sascha Hauer [this message]
2013-01-02  8:41   ` Laurent CANS
2013-01-03  8:35   ` Shawn Guo
2013-01-06 16:19     ` Laurent CANS
2013-01-07 13:01       ` Shawn Guo
2013-01-07 13:15         ` Sascha Hauer
2013-01-07 13:28           ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121219203936.GG26326@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).