From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Thu, 20 Dec 2012 23:41:46 +0000 Subject: [PATCH] ARM: dts: fix split memory bank for SSDK5440 In-Reply-To: <1464138.NEt7mMkYJc@flatron> References: <1356030217-5472-1-git-send-email-kgene.kim@samsung.com> <1464138.NEt7mMkYJc@flatron> Message-ID: <20121220234146.GF14363@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Dec 20, 2012 at 10:14:26PM +0100, Tomasz Figa wrote: > Hi Olof, > > On Thursday 20 of December 2012 11:56:59 Olof Johansson wrote: > > Hi, > > > > On Thu, Dec 20, 2012 at 11:03 AM, Kukjin Kim > wrote: > > > The size of memory bank should be under 256MB, because current > > > section size is 256MB on EXYNOS SoCs. This patch fixes it. > > > > This makes no sense. You don't have to split up memory ranges, the > > code should be made to handle it instead. > > It's not Exynos code which causes the problem. Sparsemem initialization > relies on the fact that initial amount of structures to described memory > equals to maximum section size which is defined per arch (e.g. > ARCH_EXYNOS). > > > What's the actual bug caused by this? The description is vague. > > The kernel panics early on NULL pointer dereference in memory > initialization. And of course the debugging information is included in the commit log so that others can see what problem you're experiencing and make a decision whether the proposed solution is the right one...