From: richardcochran@gmail.com (Richard Cochran)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] cpts: fix a run time warn_on.
Date: Mon, 24 Dec 2012 07:46:59 +0100 [thread overview]
Message-ID: <20121224064658.GA2390@netboy.at.omicron.at> (raw)
In-Reply-To: <50D7101A.6020506@mvista.com>
On Sun, Dec 23, 2012 at 06:07:22PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 22-12-2012 23:41, Richard Cochran wrote:
>
> >This patch fixes a warning in clk_enable by calling clk_prepare first.
>
> >Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> >---
> > drivers/net/ethernet/ti/cpts.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
>
> >diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
> >index 5ab8fb4..3e32a31 100644
> >--- a/drivers/net/ethernet/ti/cpts.c
> >+++ b/drivers/net/ethernet/ti/cpts.c
> >@@ -247,6 +247,7 @@ static void cpts_clk_init(struct cpts *cpts)
> > cpts->refclk = NULL;
> > return;
> > }
> >+ clk_prepare(cpts->refclk);
> > clk_enable(cpts->refclk);
>
> Maybe just call clk_prepare_enable() instead?
Okay, will fix in v2.
Thanks,
Richard
prev parent reply other threads:[~2012-12-24 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 19:41 [PATCH 0/2] cpts fixes for v3.8-rc2 Richard Cochran
2012-12-22 19:41 ` [PATCH 1/2] cpts: fix build error by removing useless code Richard Cochran
2012-12-22 19:41 ` [PATCH 2/2] cpts: fix a run time warn_on Richard Cochran
2012-12-23 14:07 ` Sergei Shtylyov
2012-12-24 6:46 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224064658.GA2390@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).