* [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack
@ 2012-12-23 11:16 Matt Sealey
2012-12-25 11:08 ` Shawn Guo
2012-12-27 10:49 ` Sascha Hauer
0 siblings, 2 replies; 4+ messages in thread
From: Matt Sealey @ 2012-12-23 11:16 UTC (permalink / raw)
To: linux-arm-kernel
Since Efika MX platform support (pre-devicetree) was removed from the tree
this code no longer has any possibility of running and clutters up the
driver which is being replaced by the chipidea host in the future anyway.
Signed-off-by: Matt Sealey <matt@genesi-usa.com>
Tested-by: Steev Klimazewski <steev@genesi-usa.com>
CC: Sascha Hauer <kernel@pengutronix.de>
CC: Alan Stern <stern@rowland.harvard.edu>
---
drivers/usb/host/ehci-mxc.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index 8e58a5f..b62c3a8 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -102,7 +102,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
struct usb_hcd *hcd;
struct resource *res;
int irq, ret;
- unsigned int flags;
struct ehci_mxc_priv *priv;
struct device *dev = &pdev->dev;
struct ehci_hcd *ehci;
@@ -213,25 +212,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
if (ret)
goto err_add;
- if (pdata->otg) {
- /*
- * efikamx and efikasb have some hardware bug which is
- * preventing usb to work unless CHRGVBUS is set.
- * It's in violation of USB specs
- */
- if (machine_is_mx51_efikamx() || machine_is_mx51_efikasb()) {
- flags = usb_phy_io_read(pdata->otg,
- ULPI_OTG_CTRL);
- flags |= ULPI_OTG_CTRL_CHRGVBUS;
- ret = usb_phy_io_write(pdata->otg, flags,
- ULPI_OTG_CTRL);
- if (ret) {
- dev_err(dev, "unable to set CHRVBUS\n");
- goto err_add;
- }
- }
- }
-
return 0;
err_add:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack
2012-12-23 11:16 [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack Matt Sealey
@ 2012-12-25 11:08 ` Shawn Guo
2012-12-27 10:49 ` Sascha Hauer
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2012-12-25 11:08 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Dec 23, 2012 at 05:16:02AM -0600, Matt Sealey wrote:
> Since Efika MX platform support (pre-devicetree) was removed from the tree
> this code no longer has any possibility of running and clutters up the
> driver which is being replaced by the chipidea host in the future anyway.
>
> Signed-off-by: Matt Sealey <matt@genesi-usa.com>
> Tested-by: Steev Klimazewski <steev@genesi-usa.com>
> CC: Sascha Hauer <kernel@pengutronix.de>
> CC: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack
2012-12-23 11:16 [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack Matt Sealey
2012-12-25 11:08 ` Shawn Guo
@ 2012-12-27 10:49 ` Sascha Hauer
1 sibling, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2012-12-27 10:49 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Dec 23, 2012 at 05:16:02AM -0600, Matt Sealey wrote:
> Since Efika MX platform support (pre-devicetree) was removed from the tree
> this code no longer has any possibility of running and clutters up the
> driver which is being replaced by the chipidea host in the future anyway.
>
> Signed-off-by: Matt Sealey <matt@genesi-usa.com>
> Tested-by: Steev Klimazewski <steev@genesi-usa.com>
> CC: Sascha Hauer <kernel@pengutronix.de>
> CC: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> ---
> drivers/usb/host/ehci-mxc.c | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index 8e58a5f..b62c3a8 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -102,7 +102,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
> struct usb_hcd *hcd;
> struct resource *res;
> int irq, ret;
> - unsigned int flags;
> struct ehci_mxc_priv *priv;
> struct device *dev = &pdev->dev;
> struct ehci_hcd *ehci;
> @@ -213,25 +212,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
> if (ret)
> goto err_add;
>
> - if (pdata->otg) {
> - /*
> - * efikamx and efikasb have some hardware bug which is
> - * preventing usb to work unless CHRGVBUS is set.
> - * It's in violation of USB specs
> - */
> - if (machine_is_mx51_efikamx() || machine_is_mx51_efikasb()) {
> - flags = usb_phy_io_read(pdata->otg,
> - ULPI_OTG_CTRL);
> - flags |= ULPI_OTG_CTRL_CHRGVBUS;
> - ret = usb_phy_io_write(pdata->otg, flags,
> - ULPI_OTG_CTRL);
> - if (ret) {
> - dev_err(dev, "unable to set CHRVBUS\n");
> - goto err_add;
> - }
> - }
> - }
> -
> return 0;
>
> err_add:
> --
> 1.7.10.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack
@ 2012-12-23 11:18 Matt Sealey
0 siblings, 0 replies; 4+ messages in thread
From: Matt Sealey @ 2012-12-23 11:18 UTC (permalink / raw)
To: linux-arm-kernel
Since Efika MX platform support (pre-devicetree) was removed from the tree
this code no longer has any possibility of running and clutters up the
driver which is being replaced by the chipidea host in the future anyway.
Signed-off-by: Matt Sealey <matt@genesi-usa.com>
Tested-by: Steev Klimazewski <steev@genesi-usa.com>
CC: Sascha Hauer <kernel@pengutronix.de>
CC: Alan Stern <stern@rowland.harvard.edu>
---
drivers/usb/host/ehci-mxc.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index 8e58a5f..b62c3a8 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -102,7 +102,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
struct usb_hcd *hcd;
struct resource *res;
int irq, ret;
- unsigned int flags;
struct ehci_mxc_priv *priv;
struct device *dev = &pdev->dev;
struct ehci_hcd *ehci;
@@ -213,25 +212,6 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
if (ret)
goto err_add;
- if (pdata->otg) {
- /*
- * efikamx and efikasb have some hardware bug which is
- * preventing usb to work unless CHRGVBUS is set.
- * It's in violation of USB specs
- */
- if (machine_is_mx51_efikamx() || machine_is_mx51_efikasb()) {
- flags = usb_phy_io_read(pdata->otg,
- ULPI_OTG_CTRL);
- flags |= ULPI_OTG_CTRL_CHRGVBUS;
- ret = usb_phy_io_write(pdata->otg, flags,
- ULPI_OTG_CTRL);
- if (ret) {
- dev_err(dev, "unable to set CHRVBUS\n");
- goto err_add;
- }
- }
- }
-
return 0;
err_add:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-27 10:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-23 11:16 [PATCH] ehci-mxc: remove Efika MX-specific CHRGVBUS hack Matt Sealey
2012-12-25 11:08 ` Shawn Guo
2012-12-27 10:49 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2012-12-23 11:18 Matt Sealey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).