public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: Kirkwood: Convert NS2 to gpio-poweroff.
Date: Sat, 29 Dec 2012 08:55:47 +0100	[thread overview]
Message-ID: <20121229075547.GG7578@lunn.ch> (raw)
In-Reply-To: <20121229010742.GB1357@kw.sim.vm.gnt>

On Sat, Dec 29, 2012 at 02:07:42AM +0100, Simon Guinot wrote:
> On Fri, Dec 28, 2012 at 03:14:10PM +0100, Andrew Lunn wrote:
> > Remove C code and add a Device Tree node in its place.
> > 
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > 
> > This is untested. I've been known to get the active hi/low the wrong
> > way around so that the board powers off as the driver loads at boot
> > time. So it would be very good to have a tested-by: sign off.
> 
> Hi Andrew,
> 
> I think that GPIOs are currently broken for LaCie DT boards, due to
> commit f9e75922: "ARM: Kirkwood: Make use of mvebu pincltl and gpio
> drivers".

Hi Simon

gpio-power-off should work with either the old or the new driver.

What might not work with the old code gpio power off code with the new
new driver. So it is worth giving it a try.

> As mvbu_gpio is now used (instead of orion_gpio), pinctrl must also be
> used. I think that the pinctrl conversion is a preliminary work to the
> gpio_poweroff conversion. I realized this some weeks ago while working
> on the exactly same patch. Unfortunately, I failed to find enough time
> to fix it.
> 
> If you can afford a few days delay, let's say until the end of the next
> week, I should be able to add the pinctrl conversion patch and then also
> to test your patch on the top of that.

No rush. We have maybe another 4 weeks before we need to submit code
upstream for the next merge window.

	 Andrew

  reply	other threads:[~2012-12-29  7:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-28 14:14 [PATCH 1/5] ARM: Kirkwood: Convert NS2 to gpio-poweroff Andrew Lunn
2012-12-29  1:07 ` Simon Guinot
2012-12-29  7:55   ` Andrew Lunn [this message]
2012-12-29 10:11     ` Simon Guinot
2013-01-09  8:41 ` Simon Guinot
2013-01-09  8:54   ` Andrew Lunn
2013-01-23 13:35 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121229075547.GG7578@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox