[PATCH 1/2] ARM: dts: prevent *.dtb from always being rebuilt

[PATCH 1/2] ARM: dts: prevent *.dtb from always being rebuilt

[Stephen Warren]

From: Stephen Warren <swarren@nvidia.com>

if_changed (used by the *.dts->*.dtc rule) rebuilds files if they aren't
contained in $(targets). (make V=2 indicates this). Add $(dtb-y) to
$(targets) to prevent *.dtb from always being rebuilt.

This fixes a regression introduced by the .dtb rule rework in 499cd82
"ARM: dt: change .dtb build rules to build in dts directory".

Reported-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 arch/arm/boot/dts/Makefile |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index e44da40..5ebb44f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -155,6 +155,7 @@ dtb-$(CONFIG_ARCH_VT8500) += vt8500-bv07.dtb \
 dtb-$(CONFIG_ARCH_ZYNQ) += zynq-zc702.dtb
 
 targets += dtbs
+targets += $(dtb-y)
 endif
 
 # *.dtb used to be generated in the directory above. Clean out the
-- 
1.7.10.4

[PATCH 2/2] arm64: dts: prevent *.dtb from always being rebuilt

[Stephen Warren]

From: Stephen Warren <swarren@nvidia.com>

if_changed (used by the *.dts->*.dtc rule) rebuilds files if they aren't
contained in $(targets). (make V=2 indicates this). Add $(dtb-y) to
$(targets) to prevent *.dtb from always being rebuilt. Note

This fixes a regression introduced by the .dtb rule rework in da4cbc6
"arm64: use new common dtc rule", although since arm64 doesn't actually
have any *.dts yet, this isn't a critical issue.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 arch/arm64/boot/dts/Makefile |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile
index 801e2d7..32ac0ae 100644
--- a/arch/arm64/boot/dts/Makefile
+++ b/arch/arm64/boot/dts/Makefile
@@ -1,4 +1,5 @@
 targets += dtbs
+targets += $(dtb-y)
 
 dtbs: $(addprefix $(obj)/, $(dtb-y))
 
-- 
1.7.10.4

[PATCH 1/2] ARM: dts: prevent *.dtb from always being rebuilt

[Olof Johansson]

On Fri, Dec 28, 2012 at 05:42:46PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> if_changed (used by the *.dts->*.dtc rule) rebuilds files if they aren't
> contained in $(targets). (make V=2 indicates this). Add $(dtb-y) to
> $(targets) to prevent *.dtb from always being rebuilt.
> 
> This fixes a regression introduced by the .dtb rule rework in 499cd82
> "ARM: dt: change .dtb build rules to build in dts directory".
> 
> Reported-by: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Not sure who you have in mind to apply this, but if it's not through arm-soc:

Acked-by: Olof Johansson <olof@lixom.net>


-Olof

[PATCH 1/2] ARM: dts: prevent *.dtb from always being rebuilt

[Stephen Warren]

On 12/29/2012 10:32 PM, Olof Johansson wrote:
> On Fri, Dec 28, 2012 at 05:42:46PM -0700, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> if_changed (used by the *.dts->*.dtc rule) rebuilds files if they aren't
>> contained in $(targets). (make V=2 indicates this). Add $(dtb-y) to
>> $(targets) to prevent *.dtb from always being rebuilt.
>>
>> This fixes a regression introduced by the .dtb rule rework in 499cd82
>> "ARM: dt: change .dtb build rules to build in dts directory".
>>
>> Reported-by: Shawn Guo <shawn.guo@linaro.org>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> 
> Not sure who you have in mind to apply this, but if it's not through arm-soc:
> 
> Acked-by: Olof Johansson <olof@lixom.net>

I was assuming through the device tree tree, since that's where the dtc
rule rework went through, but I think it's mostly just about whoever
picks it up:-)

[PATCH 1/2] ARM: dts: prevent *.dtb from always being rebuilt

[Rob Herring]

On 12/31/2012 10:39 AM, Stephen Warren wrote:
> On 12/29/2012 10:32 PM, Olof Johansson wrote:
>> On Fri, Dec 28, 2012 at 05:42:46PM -0700, Stephen Warren wrote:
>>> From: Stephen Warren <swarren@nvidia.com>
>>>
>>> if_changed (used by the *.dts->*.dtc rule) rebuilds files if they aren't
>>> contained in $(targets). (make V=2 indicates this). Add $(dtb-y) to
>>> $(targets) to prevent *.dtb from always being rebuilt.
>>>
>>> This fixes a regression introduced by the .dtb rule rework in 499cd82
>>> "ARM: dt: change .dtb build rules to build in dts directory".
>>>
>>> Reported-by: Shawn Guo <shawn.guo@linaro.org>
>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>
>> Not sure who you have in mind to apply this, but if it's not through arm-soc:
>>
>> Acked-by: Olof Johansson <olof@lixom.net>
> 
> I was assuming through the device tree tree, since that's where the dtc
> rule rework went through, but I think it's mostly just about whoever
> picks it up:-)
> 

I'll pick up both.

Rob