Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: ido@wizery.com (Ido Yariv)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwspinlock/core: Add testing capabilities
Date: Sun, 30 Dec 2012 17:17:22 +0200	[thread overview]
Message-ID: <20121230151722.GB16890@WorkStation.localnet> (raw)
In-Reply-To: <CAKvkGKcHfJZ++B+sq2NUZT=EDW7C+Zd3zxsOjY1MV2YA9ecE7A@mail.gmail.com>

Hi Steve,

On Sun, Dec 30, 2012 at 10:56:53PM +0800, steve.zhan wrote:
> Thanks, Ido.
> 
>       I think if hwspinlock mudule probe register have not return 0 Or
> executed over,  we can assume that system can not do acquire the
> 
> lock, that must be later than hardware module register..

That's actually not what I was concerned about. If
hwspin_lock_register_single returns 0, anyone could potentially request
and acquire that lock. If we then call hwspin_lock_tests it could
potentially fail since the lock might already be acquired and the first
call to trylock will not succeed.

Since there's no real advantage in testing the locks after registering
them, I suggest we keep the current implementation.

Thanks,
Ido.

  reply	other threads:[~2012-12-30 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-29  9:19 [PATCH] hwspinlock/core: Add testing capabilities steve.zhan
2012-12-30 11:20 ` Ido Yariv
2012-12-30 14:13   ` steve.zhan
2012-12-30 14:27     ` Ido Yariv
2012-12-30 14:56       ` steve.zhan
2012-12-30 15:17         ` Ido Yariv [this message]
2012-12-30 15:39           ` steve.zhan
  -- strict thread matches above, loose matches on Subject: below --
2012-12-12 20:27 Ido Yariv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121230151722.GB16890@WorkStation.localnet \
    --to=ido@wizery.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox