linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL
Date: Wed, 2 Jan 2013 09:28:54 +0000	[thread overview]
Message-ID: <20130102092854.GC2631@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1301020827040.2241@localhost6.localdomain6>

On Wed, Jan 02, 2013 at 08:29:57AM +0100, Julia Lawall wrote:
> There are dereferences to the result of clk_get a few times.  I tried the 
> following semantic patch:

And those are buggy; struct clk is _SUPPOSED_ to be an OPAQUE COOKIE
and no one other than the clk code should be dereferencing it.

I guess this is the danger of the common clk API - we now have a struct
clk that is exposed in a linux/*.h include which anyone can include, and
now anyone can get a definition for a struct clk and dereference it,
destroying opaqueness of this cookie.

  reply	other threads:[~2013-01-02  9:28 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18 17:34 [PATCH RESEND 0/6] Remove incorrect usage of IS_ERR_OR_NULL on clk_get Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 1/6] clk: omap: Fix incorrect usage of IS_ERR_OR_NULL Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 2/6] clk: exynos: " Tony Prisk
2012-12-18 18:48   ` Dan Carpenter
2012-12-18 17:34 ` [PATCH RESEND 3/6] " Tony Prisk
2012-12-18 18:39   ` Dan Carpenter
2012-12-18 18:52     ` Tony Prisk
2012-12-18 19:03       ` Dan Carpenter
2012-12-18 19:11         ` Tony Prisk
2012-12-18 19:39           ` Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 4/6] clk: s5p-tv: " Tony Prisk
2013-01-01 19:41   ` Sylwester Nawrocki
2012-12-18 17:34 ` [PATCH RESEND 5/6] clk: s5p-fimc: " Tony Prisk
2012-12-18 17:34 ` [PATCH RESEND 6/6] clk: s5p-g2d: " Tony Prisk
2012-12-22 21:53   ` Sergei Shtylyov
2013-01-01 18:33     ` Sylwester Nawrocki
2013-01-02  5:10       ` Dan Carpenter
2013-01-02  5:31         ` Tony Prisk
2013-01-02  7:29           ` Julia Lawall
2013-01-02  9:28             ` Russell King - ARM Linux [this message]
2013-01-03  9:05           ` Dan Carpenter
2013-01-03  9:14             ` Julia Lawall
2013-01-03 10:00               ` Russell King - ARM Linux
2013-01-03 10:00             ` Russell King - ARM Linux
2013-01-03 11:10               ` Dan Carpenter
2013-01-03 11:21                 ` Russell King - ARM Linux
2013-01-03 13:45                   ` Dan Carpenter
2013-01-03 13:52                     ` Russell King - ARM Linux
2013-01-02  9:26         ` Russell King - ARM Linux
2013-01-02  9:44           ` Julia Lawall
2013-01-02 10:15             ` Russell King - ARM Linux
2013-01-02 23:14         ` Sylwester Nawrocki
2012-12-18 18:42 ` [PATCH RESEND 0/6] Remove incorrect usage of IS_ERR_OR_NULL on clk_get Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130102092854.GC2631@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).