From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: make return_address available for ARM_UNWIND
Date: Thu, 3 Jan 2013 10:38:15 +0000 [thread overview]
Message-ID: <20130103103815.GL2631@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1357207949-3349-2-git-send-email-kpark3469@gmail.com>
On Thu, Jan 03, 2013 at 07:12:29PM +0900, kpark3469 at gmail.com wrote:
> -#if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND)
> +#if defined(CONFIG_FRAME_POINTER) || defined(CONFIG_ARM_UNWIND)
> /*
> * return_address uses walk_stackframe to do it's work. If both
> * CONFIG_FRAME_POINTER=y and CONFIG_ARM_UNWIND=y walk_stackframe uses unwind
> - * information. For this to work in the function tracer many functions would
> - * have to be marked with __notrace. So for now just depend on
> - * !CONFIG_ARM_UNWIND.
So what have you done about the issue referred in this comment? Or do you
believe that fixing warnings (even if they are explicit #warning statements)
is far more important than code being functionally correct?
next prev parent reply other threads:[~2013-01-03 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 10:12 [PATCH 1/2] arm: fix returning wrong CALLER_ADDRx kpark3469 at gmail.com
2013-01-03 10:12 ` [PATCH 2/2] arm: make return_address available for ARM_UNWIND kpark3469 at gmail.com
2013-01-03 10:38 ` Russell King - ARM Linux [this message]
2013-01-03 11:36 ` Keun-O Park
2013-01-03 13:36 ` Steven Rostedt
2013-01-03 14:13 ` Russell King - ARM Linux
2013-01-03 16:03 ` Steven Rostedt
2013-01-03 16:23 ` Russell King - ARM Linux
2013-01-03 16:58 ` Steven Rostedt
2013-01-04 8:45 ` Keun-O Park
2013-01-07 13:41 ` Steven Rostedt
2013-01-11 8:53 ` Keun-O Park
2013-01-11 22:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103103815.GL2631@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).