* Reboot hangs on Kirkwood ns2 boards with 3.8-rc2
@ 2013-01-06 3:34 Simon Guinot
2013-01-06 8:35 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Simon Guinot @ 2013-01-06 3:34 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrew and Jason,
While testing 3.8-rc2 on the ns2 boards (DT based), I noticed that
reboot is not working. After issuing a reboot, the kernel hangs. No
error messages are displayed. Moreover, on my non-DT Kirkwood boards,
reboot is working as expected.
Am I the only one to experiment this issue ?
After some painful investigations, I found out that my problem may be
related with the device tree binding addition to the driver ehci-orion.
I still don't understand exactly why, but if I add the "clocks" property
to the ehci node, reboot works.
diff --git a/arch/arm/boot/dts/kirkwood.dtsi
b/arch/arm/boot/dts/kirkwood.dtsi
index 7735cee..110d6cb 100644
--- a/arch/arm/boot/dts/kirkwood.dtsi
+++ b/arch/arm/boot/dts/kirkwood.dtsi
@@ -144,6 +144,7 @@
compatible = "marvell,orion-ehci";
reg = <0x50000 0x1000>;
interrupts = <19>;
+ clocks = <&gate_clk 3>;
status = "okay";
};
Do you have any idea ?
Regards,
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130106/d6f72a2a/attachment.sig>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Reboot hangs on Kirkwood ns2 boards with 3.8-rc2
2013-01-06 3:34 Reboot hangs on Kirkwood ns2 boards with 3.8-rc2 Simon Guinot
@ 2013-01-06 8:35 ` Andrew Lunn
2013-01-07 15:09 ` Simon Guinot
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2013-01-06 8:35 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jan 06, 2013 at 04:34:55AM +0100, Simon Guinot wrote:
> Hi Andrew and Jason,
>
> While testing 3.8-rc2 on the ns2 boards (DT based), I noticed that
> reboot is not working. After issuing a reboot, the kernel hangs. No
> error messages are displayed. Moreover, on my non-DT Kirkwood boards,
> reboot is working as expected.
>
> Am I the only one to experiment this issue ?
Hi Simon
No you are not the only one. There is a patch available, authored by
me, which is identical to what you found.
We have been a bit slow recently pushing fixes into 3.8-rc, vacations,
etc. I plan to spend some time today collecting the fixes together and
sending them upstream.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Reboot hangs on Kirkwood ns2 boards with 3.8-rc2
2013-01-06 8:35 ` Andrew Lunn
@ 2013-01-07 15:09 ` Simon Guinot
2013-01-07 15:25 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Simon Guinot @ 2013-01-07 15:09 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jan 06, 2013 at 09:35:21AM +0100, Andrew Lunn wrote:
> On Sun, Jan 06, 2013 at 04:34:55AM +0100, Simon Guinot wrote:
> > Hi Andrew and Jason,
> >
> > While testing 3.8-rc2 on the ns2 boards (DT based), I noticed that
> > reboot is not working. After issuing a reboot, the kernel hangs. No
> > error messages are displayed. Moreover, on my non-DT Kirkwood boards,
> > reboot is working as expected.
> >
> > Am I the only one to experiment this issue ?
>
> Hi Simon
>
> No you are not the only one. There is a patch available, authored by
> me, which is identical to what you found.
Arf, it's a shame I have missed this reports. It could have spared some
time by asking at you earlier.
About the issue itself. I understand that a clock is needed by the
orion-ehci driver. But even if the clock is not provided by the DT, it
should have been fixed by kirkwood_legacy_clk_init(), isn't ? What's
wrong with this workaround ?
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130107/97467bf1/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Reboot hangs on Kirkwood ns2 boards with 3.8-rc2
2013-01-07 15:09 ` Simon Guinot
@ 2013-01-07 15:25 ` Andrew Lunn
2013-01-07 15:32 ` Simon Guinot
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2013-01-07 15:25 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 07, 2013 at 04:09:18PM +0100, Simon Guinot wrote:
> On Sun, Jan 06, 2013 at 09:35:21AM +0100, Andrew Lunn wrote:
> > On Sun, Jan 06, 2013 at 04:34:55AM +0100, Simon Guinot wrote:
> > > Hi Andrew and Jason,
> > >
> > > While testing 3.8-rc2 on the ns2 boards (DT based), I noticed that
> > > reboot is not working. After issuing a reboot, the kernel hangs. No
> > > error messages are displayed. Moreover, on my non-DT Kirkwood boards,
> > > reboot is working as expected.
> > >
> > > Am I the only one to experiment this issue ?
> >
> > Hi Simon
> >
> > No you are not the only one. There is a patch available, authored by
> > me, which is identical to what you found.
>
> Arf, it's a shame I have missed this reports. It could have spared some
> time by asking at you earlier.
Hi Simon
Its often worth asking, or at least googling, before heading into a
git bisect.
> About the issue itself. I understand that a clock is needed by the
> orion-ehci driver. But even if the clock is not provided by the DT, it
> should have been fixed by kirkwood_legacy_clk_init(), isn't ? What's
> wrong with this workaround ?
kirkwood_legacy_clk_init() provides a clock with the old name. When
using DT, the device has the name "f1050000.ehci" and it looks for a
clock called "f1050000.ehci ". The legacy clock is called
"orion-ehci.0", which is what is expected when using old style
platform drivers instantiated in C.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Reboot hangs on Kirkwood ns2 boards with 3.8-rc2
2013-01-07 15:25 ` Andrew Lunn
@ 2013-01-07 15:32 ` Simon Guinot
0 siblings, 0 replies; 5+ messages in thread
From: Simon Guinot @ 2013-01-07 15:32 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 07, 2013 at 04:25:10PM +0100, Andrew Lunn wrote:
> On Mon, Jan 07, 2013 at 04:09:18PM +0100, Simon Guinot wrote:
> > On Sun, Jan 06, 2013 at 09:35:21AM +0100, Andrew Lunn wrote:
> > > On Sun, Jan 06, 2013 at 04:34:55AM +0100, Simon Guinot wrote:
> > > > Hi Andrew and Jason,
> > > >
> > > > While testing 3.8-rc2 on the ns2 boards (DT based), I noticed that
> > > > reboot is not working. After issuing a reboot, the kernel hangs. No
> > > > error messages are displayed. Moreover, on my non-DT Kirkwood boards,
> > > > reboot is working as expected.
> > > >
> > > > Am I the only one to experiment this issue ?
> > >
> > > Hi Simon
> > >
> > > No you are not the only one. There is a patch available, authored by
> > > me, which is identical to what you found.
> >
> > Arf, it's a shame I have missed this reports. It could have spared some
> > time by asking at you earlier.
>
> Hi Simon
>
> Its often worth asking, or at least googling, before heading into a
> git bisect.
>
> > About the issue itself. I understand that a clock is needed by the
> > orion-ehci driver. But even if the clock is not provided by the DT, it
> > should have been fixed by kirkwood_legacy_clk_init(), isn't ? What's
> > wrong with this workaround ?
>
> kirkwood_legacy_clk_init() provides a clock with the old name. When
> using DT, the device has the name "f1050000.ehci" and it looks for a
> clock called "f1050000.ehci ". The legacy clock is called
> "orion-ehci.0", which is what is expected when using old style
> platform drivers instantiated in C.
OK, I get it. Thanks for the explanation.
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130107/75f4c8d2/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-07 15:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-06 3:34 Reboot hangs on Kirkwood ns2 boards with 3.8-rc2 Simon Guinot
2013-01-06 8:35 ` Andrew Lunn
2013-01-07 15:09 ` Simon Guinot
2013-01-07 15:25 ` Andrew Lunn
2013-01-07 15:32 ` Simon Guinot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox