From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array
Date: Mon, 7 Jan 2013 12:03:38 -0800 [thread overview]
Message-ID: <20130107200338.GD14149@atomide.com> (raw)
In-Reply-To: <1357252342-6166-1-git-send-email-panto@antoniou-consulting.com>
* Pantelis Antoniou <panto@antoniou-consulting.com> [130103 14:35]:
> The IRQ array must be terminated by -1 and not by -1+OMAP_INTC_START
> This led to having a resource list of 100s of IRQs.
This is a bug for sure introduced with commit a2cfc509 (ARM: OMAP3+:
hwmod: Add AM33XX HWMOD data). Anybody care to ack this one?
Regards,
Tony
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index 081c71e..e402303 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> @@ -2070,7 +2070,7 @@ static struct omap_hwmod_irq_info am33xx_usbss_mpu_irqs[] = {
> { .name = "usbss-irq", .irq = 17 + OMAP_INTC_START, },
> { .name = "musb0-irq", .irq = 18 + OMAP_INTC_START, },
> { .name = "musb1-irq", .irq = 19 + OMAP_INTC_START, },
> - { .irq = -1 + OMAP_INTC_START, },
> + { .irq = -1, },
> };
>
> static struct omap_hwmod am33xx_usbss_hwmod = {
> --
> 1.7.12
>
next prev parent reply other threads:[~2013-01-07 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 22:32 [PATCH] omap: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array Pantelis Antoniou
2013-01-07 20:03 ` Tony Lindgren [this message]
2013-01-07 20:09 ` Paul Walmsley
2013-01-07 20:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107200338.GD14149@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).