* [PATCH] omap: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array
@ 2013-01-03 22:32 Pantelis Antoniou
2013-01-07 20:03 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Pantelis Antoniou @ 2013-01-03 22:32 UTC (permalink / raw)
To: linux-arm-kernel
The IRQ array must be terminated by -1 and not by -1+OMAP_INTC_START
This led to having a resource list of 100s of IRQs.
Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
---
arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
index 081c71e..e402303 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
@@ -2070,7 +2070,7 @@ static struct omap_hwmod_irq_info am33xx_usbss_mpu_irqs[] = {
{ .name = "usbss-irq", .irq = 17 + OMAP_INTC_START, },
{ .name = "musb0-irq", .irq = 18 + OMAP_INTC_START, },
{ .name = "musb1-irq", .irq = 19 + OMAP_INTC_START, },
- { .irq = -1 + OMAP_INTC_START, },
+ { .irq = -1, },
};
static struct omap_hwmod am33xx_usbss_hwmod = {
--
1.7.12
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] omap: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array
2013-01-03 22:32 [PATCH] omap: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array Pantelis Antoniou
@ 2013-01-07 20:03 ` Tony Lindgren
2013-01-07 20:09 ` Paul Walmsley
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2013-01-07 20:03 UTC (permalink / raw)
To: linux-arm-kernel
* Pantelis Antoniou <panto@antoniou-consulting.com> [130103 14:35]:
> The IRQ array must be terminated by -1 and not by -1+OMAP_INTC_START
> This led to having a resource list of 100s of IRQs.
This is a bug for sure introduced with commit a2cfc509 (ARM: OMAP3+:
hwmod: Add AM33XX HWMOD data). Anybody care to ack this one?
Regards,
Tony
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index 081c71e..e402303 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> @@ -2070,7 +2070,7 @@ static struct omap_hwmod_irq_info am33xx_usbss_mpu_irqs[] = {
> { .name = "usbss-irq", .irq = 17 + OMAP_INTC_START, },
> { .name = "musb0-irq", .irq = 18 + OMAP_INTC_START, },
> { .name = "musb1-irq", .irq = 19 + OMAP_INTC_START, },
> - { .irq = -1 + OMAP_INTC_START, },
> + { .irq = -1, },
> };
>
> static struct omap_hwmod am33xx_usbss_hwmod = {
> --
> 1.7.12
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] omap: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array
2013-01-07 20:03 ` Tony Lindgren
@ 2013-01-07 20:09 ` Paul Walmsley
2013-01-07 20:40 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Paul Walmsley @ 2013-01-07 20:09 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 7 Jan 2013, Tony Lindgren wrote:
> * Pantelis Antoniou <panto@antoniou-consulting.com> [130103 14:35]:
> > The IRQ array must be terminated by -1 and not by -1+OMAP_INTC_START
> > This led to having a resource list of 100s of IRQs.
>
> This is a bug for sure introduced with commit a2cfc509 (ARM: OMAP3+:
> hwmod: Add AM33XX HWMOD data). Anybody care to ack this one?
Acked-by: Paul Walmsley <paul@pwsan.com>
- Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] omap: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array
2013-01-07 20:09 ` Paul Walmsley
@ 2013-01-07 20:40 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-01-07 20:40 UTC (permalink / raw)
To: linux-arm-kernel
* Paul Walmsley <paul@pwsan.com> [130107 12:12]:
> On Mon, 7 Jan 2013, Tony Lindgren wrote:
>
> > * Pantelis Antoniou <panto@antoniou-consulting.com> [130103 14:35]:
> > > The IRQ array must be terminated by -1 and not by -1+OMAP_INTC_START
> > > This led to having a resource list of 100s of IRQs.
> >
> > This is a bug for sure introduced with commit a2cfc509 (ARM: OMAP3+:
> > hwmod: Add AM33XX HWMOD data). Anybody care to ack this one?
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
Thanks applying into omap-for-v3.8-rc2/fixes.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-07 20:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-03 22:32 [PATCH] omap: am33xx-hwmod: Fix wrongly terminated am33xx_usbss_mpu_irqs array Pantelis Antoniou
2013-01-07 20:03 ` Tony Lindgren
2013-01-07 20:09 ` Paul Walmsley
2013-01-07 20:40 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).