From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver
Date: Wed, 9 Jan 2013 07:15:18 +0100 [thread overview]
Message-ID: <20130109061518.GL24650@lunn.ch> (raw)
In-Reply-To: <1357681024-4686-1-git-send-email-simon.guinot@sequanux.org>
On Tue, Jan 08, 2013 at 10:37:04PM +0100, Simon Guinot wrote:
> Note that I am not sure about the MPP value for the PTP functionality.
> It seems that the PTP references have been removed from the Marvell
> hardware specifications available to me.
>
> Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
> ---
> drivers/pinctrl/mvebu/pinctrl-kirkwood.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> index fa6ce31..02d5b89 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c
> @@ -66,9 +66,9 @@ static struct mvebu_mpp_mode mv88f6xxx_mpp_modes[] = {
> MPP_VAR_FUNCTION(0x5, "sata0", "act", V(0, 1, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0xb, "lcd", "vsync", V(0, 0, 0, 0, 1, 0))),
> MPP_MODE(6,
> - MPP_VAR_FUNCTION(0x0, "sysrst", "out", V(1, 1, 1, 1, 1, 1)),
> - MPP_VAR_FUNCTION(0x1, "spi", "mosi", V(1, 1, 1, 1, 1, 1)),
> - MPP_VAR_FUNCTION(0x2, "ptp", "trig", V(1, 1, 1, 1, 0, 0))),
> + MPP_VAR_FUNCTION(0x1, "sysrst", "out", V(1, 1, 1, 1, 1, 1)),
> + MPP_VAR_FUNCTION(0x2, "spi", "mosi", V(1, 1, 1, 1, 1, 1)),
> + MPP_VAR_FUNCTION(0x3, "ptp", "trig", V(1, 1, 1, 1, 0, 0))),
> MPP_MODE(7,
> MPP_VAR_FUNCTION(0x0, "gpo", NULL, V(1, 1, 1, 1, 1, 1)),
> MPP_VAR_FUNCTION(0x1, "pex", "rsto", V(1, 1, 1, 1, 0, 1)),
> --
> 1.7.10
Acked-by: Andrew Lunn <andrew@lunn.ch>
I checked against the old MPP.H and the "88F6281 Integrated Controller
Hardware Specifications".
It is interesting that pin 6 cannot be used as a GP[IO] at all. Some
of the other pins are limited to GPO, but this appears to be the only
one which cannot be used at all.
Andrew
next prev parent reply other threads:[~2013-01-09 6:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 21:37 [PATCH] pinctrl: mvebu: fix MPP6 value for kirkwood driver Simon Guinot
2013-01-09 0:26 ` Jason Cooper
2013-01-09 6:15 ` Andrew Lunn [this message]
2013-01-18 19:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109061518.GL24650@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox