From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger
Date: Wed, 9 Jan 2013 11:59:11 +0000 [thread overview]
Message-ID: <20130109115911.GI3931@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201301091156.55644.arnd@arndb.de>
On Wed, Jan 09, 2013 at 11:56:55AM +0000, Arnd Bergmann wrote:
> On Wednesday 09 January 2013, Russell King - ARM Linux wrote:
> > > If so, that's wrong, as it covers many more boards than just Snowball
> > > and this is only applicable on the Snowball board. So how else can
> > > I enable this feature?
> >
> > And why is it wrong to enable an optional feature in a defconfig which some
> > boards using that defconfig may want?
> >
> > It's less wrong than forcing user selectable options to be mandatorily
> > selected.
>
> Right. The change I suggested fixes the build errors but doesn't actually
> make the intended behavior correct. Just using a configuration file is the
> right solution here.
Hang on a moment: if the lack of the LEDs support leads to build errors,
doesn't that mean there's missing conditional compilation?
next prev parent reply other threads:[~2013-01-09 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 10:06 [PATCH 1/3] mfd: Fix compile errors and warnings when !CONFIG_AB8500_BM Lee Jones
2013-01-09 10:06 ` [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger Lee Jones
2013-01-09 10:18 ` Arnd Bergmann
2013-01-09 10:35 ` Russell King - ARM Linux
2013-01-09 11:08 ` Lee Jones
2013-01-09 11:12 ` Russell King - ARM Linux
2013-01-09 11:56 ` Arnd Bergmann
2013-01-09 11:59 ` Russell King - ARM Linux [this message]
2013-01-09 12:02 ` Arnd Bergmann
2013-01-09 12:23 ` Lee Jones
2013-01-09 12:38 ` Russell King - ARM Linux
2013-01-09 13:00 ` Lee Jones
2013-01-17 10:22 ` Linus Walleij
2013-01-09 10:06 ` [PATCH 3/3] ARM: ux500: Add Snowball pin configuration for user LED Lee Jones
2013-01-23 9:36 ` Linus Walleij
2013-02-26 10:32 ` Lee Jones
2013-01-22 3:26 ` [PATCH 1/3] mfd: Fix compile errors and warnings when !CONFIG_AB8500_BM Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109115911.GI3931@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).