From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/3] sta2x11_vip: convert to videobuf2 and control framework
Date: Thu, 10 Jan 2013 17:01:50 +0300 [thread overview]
Message-ID: <20130110140150.GA19949@mwanda> (raw)
In-Reply-To: <1357822010-30419-3-git-send-email-federico.vaga@gmail.com>
This would be easier to review if it were broken up into separate
patches.
1) There are superflous white spaces changes
2) Changes to the copyright
3) pr_warning => pr_warn
4) The REG_READ and REG_WRITE macros are now inline functions
5) KBUILD_MODNAME is used instead of DRV_NAME
6) It now uses the video_drvdata() function
7) Lots of comments deleted. For exmple, vidioc_enum_fmt_vid_cap()
didn't change. Just the comments were deleted.
8) Comments added for existing code.
9) Other behavior changes not related to using videobuf2 like in
vidioc_try_fmt_vid_cap().
10) etc...
If all the uninteresting changes are in separate patches it makes
the complicated stuff much shorter and easier to review.
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-10 14:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 12:46 [PATCH v5] modify videobuf2-dma-contig and update sta2x11_vip Federico Vaga
2013-01-10 12:46 ` [PATCH v5 1/3] videobuf2-dma-contig: user can specify GFP flags Federico Vaga
2013-01-10 14:32 ` Federico Vaga
2013-01-10 12:46 ` [PATCH v5 2/3] sta2x11_vip: convert to videobuf2 and control framework Federico Vaga
2013-01-10 12:57 ` Federico Vaga
2013-01-10 14:41 ` Hans Verkuil
2013-01-10 14:58 ` Federico Vaga
2013-01-10 14:01 ` Dan Carpenter [this message]
2013-01-10 14:43 ` Federico Vaga
2013-01-10 12:46 ` [PATCH v5 3/3] adv7180: remove {query/g_/s_}ctrl Federico Vaga
2013-01-10 15:22 ` [PATCH v5] modify videobuf2-dma-contig and update sta2x11_vip Federico Vaga
2013-01-10 16:06 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110140150.GA19949@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).