From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: let CPUs not being able to run in ARM mode enter in THUMB mode
Date: Fri, 11 Jan 2013 16:07:53 +0000 [thread overview]
Message-ID: <20130111160753.GC23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1357904397-8476-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Fri, Jan 11, 2013 at 12:39:57PM +0100, Uwe Kleine-K?nig wrote:
> +# Select this if your CPU doesn't support the 32 bit ARM instructions.
> +config THUMBONLY_CPU
> + bool
> + select THUMB2_KERNEL
> + select ARM_THUMB
Hmm, not convinced this is the best solution. Yes, fine for there to be
a THUMBONLY_CPU option, _but_ not the select statements onto user visible
symbols. We can get this instead by:
config THUMB2_KERNEL
bool "Compile the kernel in Thumb-2 mode" if !THUMBONLY_CPU
depends on (CPU_V7 && !CPU_V6 && !CPU_V6K) || THUMBONLY_CPU
default y if THUMBONLY_CPU
select AEABI
select ARM_ASM_UNIFIED
select ARM_UNWIND
and:
config ARM_THUMB
bool "Support Thumb user binaries" if !THUMBONLY_CPU
depends on CPU_ARM720T || CPU_ARM740T || CPU_ARM920T || \
CPU_ARM922T || CPU_ARM925T || CPU_ARM926T || \
CPU_ARM940T || CPU_ARM946E || CPU_ARM1020 || \
CPU_ARM1020E || CPU_ARM1022 || CPU_ARM1026 || \
CPU_XSCALE || CPU_XSC3 || CPU_MOHAWK || CPU_V6 || \
CPU_V6K || CPU_V7 || CPU_FEROCEON || THUMBONLY_CPU
default y
And... I'm left wondering - should we have this instead:
config CPU_ARM
bool
config CPU_THUMB
bool
which indicates whether the CPU supports the ARM instruction set or the
Thumb instruction set (or both) - that should then allow us to select
those from the individual CPU_xxx options and eliminate that big long
list of dependencies against ARM_THUMB.
next prev parent reply other threads:[~2013-01-11 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 11:39 [PATCH] ARM: let CPUs not being able to run in ARM mode enter in THUMB mode Uwe Kleine-König
2013-01-11 15:34 ` Jonathan Austin
2013-01-11 15:51 ` Uwe Kleine-König
2013-01-12 17:19 ` Nicolas Pitre
2013-01-11 16:07 ` Russell King - ARM Linux [this message]
2013-01-11 16:20 ` Uwe Kleine-König
2013-01-14 9:50 ` Uwe Kleine-König
2013-01-11 18:00 ` Jonathan Austin
2013-01-11 18:12 ` Russell King - ARM Linux
2013-01-14 11:15 ` [PATCH v2] " Uwe Kleine-König
2013-01-14 21:53 ` Nicolas Pitre
2013-01-29 12:44 ` [PATCH] " Dave Martin
2013-01-31 15:51 ` Uwe Kleine-König
2013-02-19 11:39 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111160753.GC23505@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).