From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: ERROR: "__aeabi_uldivmod" [drivers/pinctrl/pinctrl-single.ko] undefined!
Date: Fri, 11 Jan 2013 15:38:01 -0800 [thread overview]
Message-ID: <20130111233801.GP14149@atomide.com> (raw)
In-Reply-To: <CACRpkdYd9br=9G7FvjbKCebfMjqX6xcL5Oge+07MPTNadPapKw@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [130111 12:47]:
> On Fri, Jan 11, 2013 at 4:00 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>
> > The above error happens in builds including pinctrl-single - the reason
> > is this, where resource_size_t may be 64-bit.
> >
> > gpio->range.pin_base = (r.start - pcs->res->start) / mux_bytes;
> > gpio->range.npins = (r.end - r.start) / mux_bytes + 1;
> >
> > This leads to a 64-bit division by an extended 64-bit, resulting in the
> > call to our (unimplemented) 64-bit-by-64-bit division routines.
> >
> > This needs fixing - you probably want to cast the difference down to an
> > 'unsigned' first, and also maybe check that it does fit in an unsigned
> > too?
>
> Agreed, Haojian can you provide a tested patch for this?
> I think you added this code...
>
> Tony: please check and ACK.
OK will check and ack.
Tony
prev parent reply other threads:[~2013-01-11 23:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 15:00 ERROR: "__aeabi_uldivmod" [drivers/pinctrl/pinctrl-single.ko] undefined! Russell King - ARM Linux
2013-01-11 20:44 ` Linus Walleij
2013-01-11 23:38 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111233801.GP14149@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).