linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: max77686: Fix return value checking for devm_kzalloc
Date: Fri, 11 Jan 2013 18:56:38 -0800	[thread overview]
Message-ID: <20130112025638.4361.85705@quantum> (raw)
In-Reply-To: <1355816625.32595.0.camel@phoenix>

Quoting Axel Lin (2012-12-17 23:43:45)
> devm_kzalloc returns NULL on failure.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Pulled into clk-next.

Thanks for the patch,
Mike

> ---
>  drivers/clk/clk-max77686.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
> index d098f72..8944214 100644
> --- a/drivers/clk/clk-max77686.c
> +++ b/drivers/clk/clk-max77686.c
> @@ -132,7 +132,7 @@ static int max77686_clk_register(struct device *dev,
>  
>         max77686->lookup = devm_kzalloc(dev, sizeof(struct clk_lookup),
>                                         GFP_KERNEL);
> -       if (IS_ERR(max77686->lookup))
> +       if (!max77686->lookup)
>                 return -ENOMEM;
>  
>         max77686->lookup->con_id = hw->init->name;
> @@ -151,13 +151,13 @@ static int max77686_clk_probe(struct platform_device *pdev)
>  
>         max77686_clks = devm_kzalloc(&pdev->dev, sizeof(struct max77686_clk *)
>                                         * MAX77686_CLKS_NUM, GFP_KERNEL);
> -       if (IS_ERR(max77686_clks))
> +       if (!max77686_clks)
>                 return -ENOMEM;
>  
>         for (i = 0; i < MAX77686_CLKS_NUM; i++) {
>                 max77686_clks[i] = devm_kzalloc(&pdev->dev,
>                                         sizeof(struct max77686_clk), GFP_KERNEL);
> -               if (IS_ERR(max77686_clks[i]))
> +               if (!max77686_clks[i])
>                         return -ENOMEM;
>         }
>  
> -- 
> 1.7.9.5

      reply	other threads:[~2013-01-12  2:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18  7:43 [PATCH] clk: max77686: Fix return value checking for devm_kzalloc Axel Lin
2013-01-12  2:56 ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130112025638.4361.85705@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).