linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 V4] iio: mxs: Implement support for touchscreen
Date: Sun, 13 Jan 2013 15:13:36 +0100	[thread overview]
Message-ID: <201301131513.36953.marex@denx.de> (raw)
In-Reply-To: <50F2922F.904@kernel.org>

Dear Jonathan Cameron,

> On 01/13/2013 03:09 AM, Dmitry Torokhov wrote:
> > On Sat, Jan 12, 2013 at 12:35:07AM +0100, Marek Vasut wrote:
> >> This patch implements support for sampling of a touchscreen into
> >> the MXS LRADC driver. The LRADC block allows configuring some of
> >> it's channels into special mode where they either output the drive
> >> voltage or sample it, allowing it to operate a 4-wire or 5-wire
> >> resistive touchscreen.
> >> 
> >> In case the touchscreen mode is enabled, the LRADC slot #7 is
> >> reserved for touchscreen only, therefore it is not possible to
> >> sample 8 LRADC channels at time, but only 7 channels.
> >> 
> >> The touchscreen controller is configured such that the PENDOWN event
> >> disables touchscreen interrupts and triggers execution of worker
> >> thread, which then polls the touchscreen controller for X, Y and
> >> Pressure values. This reduces the overhead of interrupt-driven
> >> operation. Upon the PENUP event, the worker thread re-enables the
> >> PENDOWN detection interrupt and exits.
> >> 
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > 
> > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> I've added this to the togreg branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
> 
> Note it did not directly apply as I'm guessing you have a slightly
> out of date tree.

Ah yes, it was still based off of stable 3.7 .

> Please could you check I didn't mess up the
> fixing up of the patch. There was a fair bit of fuzz and the devinit
> devexit stuff shouldn't have been in your patch in the first place.

Checked just now, looks OK to me, thanks!

> Shawn, do you want to take the board device tree patch or shall
> I take that one as well?
> 
> Jonathan

      parent reply	other threads:[~2013-01-13 14:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 23:35 [PATCH 1/2 V4] iio: mxs: Implement support for touchscreen Marek Vasut
2013-01-11 23:35 ` [PATCH 2/2] iio: mxs: Enable touchscreen on m28evk Marek Vasut
2013-01-14  0:50   ` Shawn Guo
2013-01-14  0:53     ` Marek Vasut
2013-01-13  3:09 ` [PATCH 1/2 V4] iio: mxs: Implement support for touchscreen Dmitry Torokhov
2013-01-13 10:53   ` Jonathan Cameron
2013-01-13 11:45     ` Shawn Guo
2013-01-13 14:13     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301131513.36953.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).