From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] serial: vt8500: UART uses gated clock rather than 24Mhz reference
Date: Mon, 14 Jan 2013 09:20:07 +0000 [thread overview]
Message-ID: <20130114092007.GW23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1358129060-9399-4-git-send-email-linux@prisktech.co.nz>
On Mon, Jan 14, 2013 at 03:04:18PM +1300, Tony Prisk wrote:
> - if (vt8500_port->clk) {
> - vt8500_port->uart.uartclk = clk_get_rate(vt8500_port->clk);
> - } else {
> - /* use the default of 24Mhz if not specified and warn */
> - pr_warn("%s: serial clock source not specified\n", __func__);
> - vt8500_port->uart.uartclk = 24000000;
> + if (IS_ERR(vt8500_port->clk)) {
> + dev_err(&pdev->dev, "failed to get clock\n");
> + ret = -EINVAL;
> + goto err;
> + }
> +
> + ret = clk_prepare_enable(vt8500_port->clk);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to enable clock\n");
> + goto err;
Looks like you get rid of the initialization of vt8500_port->uart.uartclk
here. Was that intentional?
next prev parent reply other threads:[~2013-01-14 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 2:04 [GIT PULL] Fixes/cleanup for vt8500 serial driver Tony Prisk
2013-01-14 2:04 ` [PATCH 1/4] serial: vt8500: Fix range-checking on vt8500_uart_ports Tony Prisk
2013-01-14 2:04 ` [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed Tony Prisk
2013-01-14 13:37 ` Sergei Shtylyov
2013-01-14 2:04 ` [PATCH 3/4] serial: vt8500: UART uses gated clock rather than 24Mhz reference Tony Prisk
2013-01-14 9:20 ` Russell King - ARM Linux [this message]
2013-01-14 2:04 ` [PATCH 4/4] serial: tty: Cleanup code using devm_ function Tony Prisk
-- strict thread matches above, loose matches on Subject: below --
2013-01-15 4:58 [GIT PULL v2] Fixes/cleanup for vt8500 serial driver Tony Prisk
2013-01-15 4:58 ` [PATCH 3/4] serial: vt8500: UART uses gated clock rather than 24Mhz reference Tony Prisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114092007.GW23505@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).