From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND
Date: Tue, 15 Jan 2013 10:03:24 -0800 [thread overview]
Message-ID: <20130115180324.GZ14149@atomide.com> (raw)
In-Reply-To: <CACTFLAMT2-6VRkNSO3OF6X=afTYKRz=JcDkYqqyZ4VNT5xBVkw@mail.gmail.com>
* Daniel Mack <zonque@gmail.com> [130114 15:30]:
> On Jan 15, 2013 2:06 AM, "Tony Lindgren" <tony@atomide.com> wrote:
> >
> > * Ezequiel Garcia <elezegarcia@gmail.com> [121223 13:49]:
> > > On Fri, Dec 14, 2012 at 7:36 AM, Daniel Mack <zonque@gmail.com> wrote:
> > > > +
> > > > +Example for an AM33xx board:
> > > > +
> > > > + gpmc: gpmc at 50000000 {
> > > > + compatible = "ti,am3352-gpmc";
> > > > + ti,hwmods = "gpmc";
> > > > + reg = <0x50000000 0x1000000>;
> > > > + interrupts = <100>;
> > > > + gpmc,num-cs = <8>;
> > > > + gpmc,num-waitpins = <2>;
> > > > + #address-cells = <2>;
> > > > + #size-cells = <1>;
> > > > + ranges = <0 0 0x08000000 0x2000>; /* CS0: NAND
> */
> > > > +
> > > > + nand at 0,0 {
> > > > + reg = <0 0 0>; /* CS0, offset 0 */
> > >
> > > I'm a bit confused by this: what are the other two values in "reg"?
> > > I see you've only added a binding for CS.
> > >
> > > I've extended a bit on your work and added a binding to enable OneNAND
> > > device on my IGEP board.
> > >
> > > I might send some patches in case anyone wants to give it a try.
> >
> > Daniel, should this be updated to just pass the CS?
>
> No, as Rob pointed out earlier in a thread about this topic, the 'ranges'
> feature will help doing the math for the offset calculation eventually, so
> we need to pass all three values.
OK thanks. Applying this set into omap-for-v3.9/gpmc.
Also sounds like Ezequiel needs to update his follow up patches accordingly.
Regards,
Tony
next prev parent reply other threads:[~2013-01-15 18:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 10:36 [PATCH v8 0/5] OMAP GPMC DT bindings Daniel Mack
2012-12-14 10:36 ` [PATCH v8 1/5] ARM: OMAP: gpmc: don't create devices from initcall on DT Daniel Mack
2012-12-14 10:36 ` [PATCH v8 2/5] mtd: omap-nand: pass device_node in platform data Daniel Mack
2013-01-15 18:52 ` Tony Lindgren
2013-01-15 19:09 ` Artem Bityutskiy
2013-01-15 19:26 ` Tony Lindgren
2013-01-15 19:35 ` Artem Bityutskiy
2012-12-14 10:36 ` [PATCH v8 3/5] ARM: OMAP: gpmc-nand: drop __init annotation Daniel Mack
2012-12-14 10:36 ` [PATCH v8 4/5] ARM: OMAP: gpmc: enable hwecc for AM33xx SoCs Daniel Mack
2012-12-14 10:36 ` [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND Daniel Mack
2012-12-15 7:27 ` Grant Likely
2012-12-24 1:07 ` Daniel Mack
2012-12-23 21:46 ` Ezequiel Garcia
2013-01-14 18:06 ` Tony Lindgren
2013-01-14 23:26 ` Daniel Mack
2013-01-15 18:03 ` Tony Lindgren [this message]
2013-01-15 18:10 ` Ezequiel Garcia
2013-01-15 18:56 ` Tony Lindgren
2013-01-18 19:39 ` Ezequiel Garcia
2013-01-18 21:11 ` Tony Lindgren
2013-01-18 22:12 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115180324.GZ14149@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).