From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] W1: Support onewire master on i.MX53
Date: Wed, 16 Jan 2013 11:44:44 +0100 [thread overview]
Message-ID: <20130116104444.GS1906@pengutronix.de> (raw)
In-Reply-To: <20130116094821.9660.18278.stgit@localhost>
Hi Martin,
On Wed, Jan 16, 2013 at 10:48:21AM +0100, Martin Fuzzey wrote:
> W1: Support onewire master on i.MX53
> * Add device tree and pinctrl support to the MXC master driver
> * Add i.MX53 clocks
> * Add i.MX53 device tree entries
>
> The final patch converts the driver to use devm_
Looks mostly good. I think the patch converting to devm_ should come
before the one adding pinctrl for the driver, just because the driver
should first be switched to devm_ and afterwards the devm_ usage should
be extended.
Other than that I just noticed that the clk_prepare_enable/clk_disable_unprepare
is unbalanced in the error case of the driver (clk_disable_unprepare
missing after the failed_add label). Might be worth fixing this in this series.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-01-16 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 9:48 [PATCH 0/5] W1: Support onewire master on i.MX53 Martin Fuzzey
2013-01-16 9:48 ` [PATCH 1/5] W1: Add device tree support to MXC onewire master Martin Fuzzey
2013-01-16 16:36 ` Mark Rutland
2013-01-16 18:11 ` Martin Fuzzey
2013-01-16 9:48 ` [PATCH 2/5] ARM: i.MX53: Add clocks for i.mx53 " Martin Fuzzey
2013-01-16 9:48 ` [PATCH 3/5] DTS: Add device tree entry for onewire master on i.MX53 Martin Fuzzey
2013-01-16 9:48 ` [PATCH 4/5] W1: Add pinctrl support to MXC onewire master Martin Fuzzey
2013-01-16 9:48 ` [PATCH 5/5] W1: Convert MXC onewire master to devm_ functions Martin Fuzzey
2013-01-16 10:44 ` Sascha Hauer [this message]
2013-01-16 14:17 ` [PATCH 0/5] W1: Support onewire master on i.MX53 Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116104444.GS1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).