[PATCH 1/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP

[PATCH 1/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP

[Ezequiel Garcia]

The Armada 370 and Armada XP SoC has an Orion EHCI USB controller.
This patch adds support for this controller in Armada 370
and Armada XP SoC common device tree files.

Cc: Lior Amsalem <alior@marvell.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/boot/dts/armada-370-xp.dtsi |   15 +++++++++++++++
 arch/arm/boot/dts/armada-370.dtsi    |    9 +++++++++
 arch/arm/boot/dts/armada-xp.dtsi     |   17 +++++++++++++++++
 arch/arm/mach-mvebu/Kconfig          |    1 +
 4 files changed, 42 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
index 28276fe..fa025c4 100644
--- a/arch/arm/boot/dts/armada-370-xp.dtsi
+++ b/arch/arm/boot/dts/armada-370-xp.dtsi
@@ -145,6 +145,21 @@
 			clocks = <&gateclk 17>;
 			status = "disabled";
 		};
+
+		usb at d0050000 {
+			compatible = "marvell,orion-ehci";
+			reg = <0xd0050000 0x500>;
+			interrupts = <45>;
+			status = "disabled";
+		};
+
+		usb at d0051000 {
+			compatible = "marvell,orion-ehci";
+			reg = <0xd0051000 0x500>;
+			interrupts = <46>;
+			status = "disabled";
+		};
+
 	};
 };
 
diff --git a/arch/arm/boot/dts/armada-370.dtsi b/arch/arm/boot/dts/armada-370.dtsi
index 88f9bab..8188d13 100644
--- a/arch/arm/boot/dts/armada-370.dtsi
+++ b/arch/arm/boot/dts/armada-370.dtsi
@@ -144,5 +144,14 @@
 				dmacap,memset;
 			};
 		};
+
+		usb at d0050000 {
+			clocks = <&coreclk 0>;
+		};
+
+		usb at d0051000 {
+			clocks = <&coreclk 0>;
+		};
+
 	};
 };
diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
index 390ba98..1443949 100644
--- a/arch/arm/boot/dts/armada-xp.dtsi
+++ b/arch/arm/boot/dts/armada-xp.dtsi
@@ -134,5 +134,22 @@
 				dmacap,memset;
 			};
 		};
+
+		usb at d0050000 {
+			clocks = <&gateclk 18>;
+		};
+
+		usb at d0051000 {
+			clocks = <&gateclk 19>;
+		};
+
+		usb at d0052000 {
+			compatible = "marvell,orion-ehci";
+			reg = <0xd0052000 0x500>;
+			interrupts = <47>;
+			clocks = <&gateclk 20>;
+			status = "disabled";
+		};
+
 	};
 };
diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 440b13e..5e4fcde 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -24,6 +24,7 @@ config MACH_ARMADA_370_XP
 	select HAVE_SMP
 	select CACHE_L2X0
 	select CPU_PJ4B
+	select USB_ARCH_HAS_EHCI if USB_SUPPORT
 
 config MACH_ARMADA_370
 	bool "Marvell Armada 370 boards"
-- 
1.7.8.6

[PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board

[Ezequiel Garcia]

Cc: Lior Amsalem <alior@marvell.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/boot/dts/armada-370-db.dts |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/armada-370-db.dts b/arch/arm/boot/dts/armada-370-db.dts
index 8e66a7c..3d93902 100644
--- a/arch/arm/boot/dts/armada-370-db.dts
+++ b/arch/arm/boot/dts/armada-370-db.dts
@@ -74,5 +74,13 @@
 			status = "disabled";
 			/* No CD or WP GPIOs */
 		};
+
+		usb at d0050000 {
+			status = "okay";
+		};
+
+		usb at d0051000 {
+			status = "okay";
+		};
 	};
 };
-- 
1.7.8.6

[PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board

[Arnd Bergmann]

On Tuesday 15 January 2013, Ezequiel Garcia wrote:
> Cc: Lior Amsalem <alior@marvell.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

The patches look good, but when you have four trivial patches
doing the same thing in different files, and you decide that it's
not worth writing a changelog for them, they should probably
go into a single patch.

	Arnd

[PATCH 2/6] arm: mvebu: Enable USB controllers on Armada 370 evaluation board

[Ezequiel Garcia]

Hi Arnd,

On 01/15/2013 10:07 AM, Arnd Bergmann wrote:
> On Tuesday 15 January 2013, Ezequiel Garcia wrote:
>> Cc: Lior Amsalem <alior@marvell.com>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> 
> The patches look good, but when you have four trivial patches
> doing the same thing in different files, and you decide that it's
> not worth writing a changelog for them, they should probably
> go into a single patch.
>

Mmm... maybe you're right and such splitting is excessive.
It seemed tidier this way, enabling each board on a different patch.

I can squash them on a v2, if you want me to.

Thanks for reviewing!

-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

[PATCH 3/6] arm: mvebu: Enable USB controllers on Armada 370 Mirabox board

[Ezequiel Garcia]

Cc: Lior Amsalem <alior@marvell.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/boot/dts/armada-370-mirabox.dts |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/armada-370-mirabox.dts b/arch/arm/boot/dts/armada-370-mirabox.dts
index 1864820..dd0c57d 100644
--- a/arch/arm/boot/dts/armada-370-mirabox.dts
+++ b/arch/arm/boot/dts/armada-370-mirabox.dts
@@ -62,5 +62,13 @@
 			 * Wifi/Bluetooth chip
 			 */
 		};
+
+		usb at d0050000 {
+			status = "okay";
+		};
+
+		usb at d0051000 {
+			status = "okay";
+		};
 	};
 };
-- 
1.7.8.6

[PATCH 4/6] arm: mvebu: Enable USB controllers on Armada XP evaluation board

[Ezequiel Garcia]

Cc: Lior Amsalem <alior@marvell.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/boot/dts/armada-xp-db.dts |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/armada-xp-db.dts b/arch/arm/boot/dts/armada-xp-db.dts
index c7035c5..c84e1fe 100644
--- a/arch/arm/boot/dts/armada-xp-db.dts
+++ b/arch/arm/boot/dts/armada-xp-db.dts
@@ -97,5 +97,17 @@
 			status = "okay";
 			/* No CD or WP GPIOs */
 		};
+
+		usb at d0050000 {
+			status = "okay";
+		};
+
+		usb at d0051000 {
+			status = "okay";
+		};
+
+		usb at d0052000 {
+			status = "okay";
+		};
 	};
 };
-- 
1.7.8.6

[PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

[Ezequiel Garcia]

Cc: Lior Amsalem <alior@marvell.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
index b24644f..55f5b6f 100644
--- a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
+++ b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
@@ -127,5 +127,14 @@
 			nr-ports = <2>;
 			status = "okay";
 		};
+		usb at d0050000 {
+			status = "okay";
+		};
+		usb at d0051000 {
+			status = "okay";
+		};
+		usb at d0052000 {
+			status = "okay";
+		};
 	};
 };
-- 
1.7.8.6

[PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

[Nobuhiro Iwamatsu]

Hi,



On Tue, Jan 15, 2013 at 6:54 PM, Ezequiel Garcia
<ezequiel.garcia@free-electrons.com> wrote:
> Cc: Lior Amsalem <alior@marvell.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
>  arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
> index b24644f..55f5b6f 100644
> --- a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
> +++ b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
> @@ -127,5 +127,14 @@
>                         nr-ports = <2>;
>                         status = "okay";
>                 };
> +               usb at d0050000 {
> +                       status = "okay";
> +               };
> +               usb at d0051000 {
> +                       status = "okay";
> +               };
> +               usb at d0052000 {
> +                       status = "okay";
> +               };
USB2 of openblocks-ax3-4 is used as Mini-PCIE.
I think this is unnecessary.

>         };
>  };
> --
> 1.7.8.6
>

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

[PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

[Ezequiel Garcia]

Hi Nobuhiro,

On Tue, Jan 15, 2013 at 9:01 PM, Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
> Hi,
>
>
>
> On Tue, Jan 15, 2013 at 6:54 PM, Ezequiel Garcia
> <ezequiel.garcia@free-electrons.com> wrote:
>> Cc: Lior Amsalem <alior@marvell.com>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>> ---
>>  arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts |    9 +++++++++
>>  1 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
>> index b24644f..55f5b6f 100644
>> --- a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
>> +++ b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts
>> @@ -127,5 +127,14 @@
>>                         nr-ports = <2>;
>>                         status = "okay";
>>                 };
>> +               usb at d0050000 {
>> +                       status = "okay";
>> +               };
>> +               usb at d0051000 {
>> +                       status = "okay";
>> +               };
>> +               usb at d0052000 {
>> +                       status = "okay";
>> +               };
> USB2 of openblocks-ax3-4 is used as Mini-PCIE.
> I think this is unnecessary.
>

Mmm... could you explain this with some more detail.
Unfortunately, I don't have access to an Openblocks board to check on this,
so I'd appreciate any clarification.

Is there any Openblocks datasheet or hardware schematics publicly
available for me to look at?

Thanks a lot,

-- 
    Ezequiel

[PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

[Thomas Petazzoni]

Dear Ezequiel Garcia,

On Wed, 16 Jan 2013 16:16:59 -0300, Ezequiel Garcia wrote:

> >> +               usb at d0050000 {
> >> +                       status = "okay";
> >> +               };
> >> +               usb at d0051000 {
> >> +                       status = "okay";
> >> +               };
> >> +               usb at d0052000 {
> >> +                       status = "okay";
> >> +               };
> > USB2 of openblocks-ax3-4 is used as Mini-PCIE.
> > I think this is unnecessary.
> 
> Mmm... could you explain this with some more detail.
> Unfortunately, I don't have access to an Openblocks board to check on
> this, so I'd appreciate any clarification.
> 
> Is there any Openblocks datasheet or hardware schematics publicly
> available for me to look at?

As far as I know, there is no public document. I've been given access
to a PDF, in Japanese, that gives some details about the hardware.

>From what I can read, only 2 USB ports are used from the internal
Marvell EHCI controller.

Another USB port is available, but it is connected to a USB controller
that sits on the PCIe bus. And the PCIe interface on which this USB
controller is connected is not enabled in the default U-Boot shipped
with AX3-4 (at least not with the generation I have). I've been given
an U-Boot version that is supposed to enable this PCIe interface, but I
haven't tested yet.

Anyway, from a Marvell EHCI controller perspective, only two ports are
used, as Nobuhiro said. I am not sure which ports, but it seems like
the first two ones were used. One of the two physical ports is a
combined USB / eSATA port, but I don't think this makes any difference
at the software level.

I don't have the OpenBlocks AX3-4 with me right now, but I could
probably make a test on Friday.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

[Nobuhiro Iwamatsu]

Hi,

Thomas, Thank you for the detailed explanation.

Ezequiel, I checked your patch on OpenBlocks AX3, work fine.

But I have a question. your patch "arm: mvebu: Add support for USB
host controllers in Armada 370/XP"
was set USB controller of 0xd0050000 to IRQ 45. I think this is 47,
and 0xd0052000 is 45.
Because manual has been written irq 45 is USB2.
I'm sorry if if my lack of understanding or typo in the manual.

Best regards,
  Nobuhiro

On Thu, Jan 17, 2013 at 4:37 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Ezequiel Garcia,
>
> On Wed, 16 Jan 2013 16:16:59 -0300, Ezequiel Garcia wrote:
>
>> >> +               usb at d0050000 {
>> >> +                       status = "okay";
>> >> +               };
>> >> +               usb at d0051000 {
>> >> +                       status = "okay";
>> >> +               };
>> >> +               usb at d0052000 {
>> >> +                       status = "okay";
>> >> +               };
>> > USB2 of openblocks-ax3-4 is used as Mini-PCIE.
>> > I think this is unnecessary.
>>
>> Mmm... could you explain this with some more detail.
>> Unfortunately, I don't have access to an Openblocks board to check on
>> this, so I'd appreciate any clarification.
>>
>> Is there any Openblocks datasheet or hardware schematics publicly
>> available for me to look at?
>
> As far as I know, there is no public document. I've been given access
> to a PDF, in Japanese, that gives some details about the hardware.
>
> From what I can read, only 2 USB ports are used from the internal
> Marvell EHCI controller.
>
> Another USB port is available, but it is connected to a USB controller
> that sits on the PCIe bus. And the PCIe interface on which this USB
> controller is connected is not enabled in the default U-Boot shipped
> with AX3-4 (at least not with the generation I have). I've been given
> an U-Boot version that is supposed to enable this PCIe interface, but I
> haven't tested yet.
>
> Anyway, from a Marvell EHCI controller perspective, only two ports are
> used, as Nobuhiro said. I am not sure which ports, but it seems like
> the first two ones were used. One of the two physical ports is a
> combined USB / eSATA port, but I don't think this makes any difference
> at the software level.
>
> I don't have the OpenBlocks AX3-4 with me right now, but I could
> probably make a test on Friday.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

[PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

[Gregory CLEMENT]

On 01/19/2013 01:07 AM, Nobuhiro Iwamatsu wrote:
> Hi,
> 
> Thomas, Thank you for the detailed explanation.
> 
> Ezequiel, I checked your patch on OpenBlocks AX3, work fine.
> 
> But I have a question. your patch "arm: mvebu: Add support for USB
> host controllers in Armada 370/XP"
> was set USB controller of 0xd0050000 to IRQ 45. I think this is 47,
> and 0xd0052000 is 45.
> Because manual has been written irq 45 is USB2.
> I'm sorry if if my lack of understanding or typo in the manual.

It was a typo in the manual, and we have spent some time to figure
it out!


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 5/6] arm: mvebu: Enable USB controllers on Armada XP OpenBlocks AX3-4 board

[Nobuhiro Iwamatsu]

Hi,

On Sat, Jan 19, 2013 at 9:11 AM, Gregory CLEMENT
<gregory.clement@free-electrons.com> wrote:
> On 01/19/2013 01:07 AM, Nobuhiro Iwamatsu wrote:
>> Hi,
>>
>> Thomas, Thank you for the detailed explanation.
>>
>> Ezequiel, I checked your patch on OpenBlocks AX3, work fine.
>>
>> But I have a question. your patch "arm: mvebu: Add support for USB
>> host controllers in Armada 370/XP"
>> was set USB controller of 0xd0050000 to IRQ 45. I think this is 47,
>> and 0xd0052000 is 45.
>> Because manual has been written irq 45 is USB2.
>> I'm sorry if if my lack of understanding or typo in the manual.
>
> It was a typo in the manual, and we have spent some time to figure
> it out!
>

I see, thanks for your comment.

Tested-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

[PATCH 6/6] arm: mvebu: Update defconfig to select USB support

[Ezequiel Garcia]

Cc: Lior Amsalem <alior@marvell.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/configs/mvebu_defconfig |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/arch/arm/configs/mvebu_defconfig b/arch/arm/configs/mvebu_defconfig
index c3c6326..f8d0183 100644
--- a/arch/arm/configs/mvebu_defconfig
+++ b/arch/arm/configs/mvebu_defconfig
@@ -42,7 +42,10 @@ CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_SERIAL_8250_DW=y
 CONFIG_GPIOLIB=y
 CONFIG_GPIO_SYSFS=y
-# CONFIG_USB_SUPPORT is not set
+CONFIG_USB_SUPPORT=y
+CONFIG_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_ROOT_HUB_TT=y
 CONFIG_MMC=y
 CONFIG_MMC_MVSDIO=y
 CONFIG_RTC_CLASS=y
-- 
1.7.8.6

[PATCH 1/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP

[Florian Fainelli]

Hello Ezequiel,

Le 01/15/13 10:54, Ezequiel Garcia a ?crit :
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 440b13e..5e4fcde 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -24,6 +24,7 @@ config MACH_ARMADA_370_XP
>   	select HAVE_SMP
>   	select CACHE_L2X0
>   	select CPU_PJ4B
> +	select USB_ARCH_HAS_EHCI if USB_SUPPORT

I do not think this is actually required because ARCH_MVEBU selects 
PLAT_ORION and in drivers/usb/host/Kconfig, USB_ARCH_HAS_EHCI is default 
y if PLAT_ORION. Having USB_ARCH_HAS_EHCI without USB_SUPPORT enabled is 
pretty harmless.
--
Florian

[PATCH 1/6] arm: mvebu: Add support for USB host controllers in Armada 370/XP

[Ezequiel Garcia]

Hi Florian,

On 01/15/2013 07:23 AM, Florian Fainelli wrote:
> Le 01/15/13 10:54, Ezequiel Garcia a ?crit :
>> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
>> index 440b13e..5e4fcde 100644
>> --- a/arch/arm/mach-mvebu/Kconfig
>> +++ b/arch/arm/mach-mvebu/Kconfig
>> @@ -24,6 +24,7 @@ config MACH_ARMADA_370_XP
>>       select HAVE_SMP
>>       select CACHE_L2X0
>>       select CPU_PJ4B
>> +    select USB_ARCH_HAS_EHCI if USB_SUPPORT
> 
> I do not think this is actually required because ARCH_MVEBU selects PLAT_ORION and in drivers/usb/host/Kconfig, USB_ARCH_HAS_EHCI is default y if PLAT_ORION. Having USB_ARCH_HAS_EHCI without USB_SUPPORT enabled is pretty harmless.

Yes, you're right, this is not needed.

Nice catch and thanks for the review,

-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com