linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors
Date: Thu, 17 Jan 2013 11:04:38 +0000	[thread overview]
Message-ID: <20130117110438.GZ23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1358420507.2394.19.camel@dabdike.int.hansenpartnership.com>

On Thu, Jan 17, 2013 at 11:01:47AM +0000, James Bottomley wrote:
> On Thu, 2013-01-17 at 10:47 +0000, Russell King - ARM Linux wrote:
> > Also, couldn't the addition of the scatterlist offset to the page also
> > be buggy too?
> 
> No, fortunately, offset must be within the first page from the point of
> view of block generated sg lists.  As long as nothing within arm
> violates this, it should be a safe assumption ... although the code
> seems to assume otherwise.

Are you absolutely sure about that?  I believe I have seen cases where
that has been violated in the past, though it was many years ago.

  reply	other threads:[~2013-01-17 11:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1358265681-25671-1-git-send-email-subhashj@codeaurora.org>
     [not found] ` <1358266794.10591.8.camel@dabdike.int.hansenpartnership.com>
     [not found]   ` <50F64AC1.3040304@codeaurora.org>
2013-01-16 10:32     ` [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors James Bottomley
2013-01-16 12:39       ` Subhash Jadavani
2013-01-16 12:47         ` ARM DMA: Fix in dma_cache_maint_page Subhash Jadavani
2013-01-16 12:51           ` James Bottomley
2013-01-16 13:08             ` Russell King - ARM Linux
2013-01-16 15:50               ` James Bottomley
2013-01-16 23:14       ` [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors Russell King - ARM Linux
2013-01-17  8:54         ` James Bottomley
2013-01-16 23:18       ` Tejun Heo
2013-01-17  9:11         ` James Bottomley
2013-01-17 10:37           ` Russell King - ARM Linux
2013-01-17 10:47             ` Russell King - ARM Linux
2013-01-17 11:01               ` James Bottomley
2013-01-17 11:04                 ` Russell King - ARM Linux [this message]
2013-01-17 11:19                   ` James Bottomley
2013-01-17 11:40                     ` Russell King - ARM Linux
2013-01-17 14:58               ` Subhash Jadavani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130117110438.GZ23505@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).