[PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

[PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

[Peter Korsgaard]

>>>>> "Michal" == Michal Bachraty <michal.bachraty@gmail.com> writes:

Hi Michael,

 Michal> I made changes to cpsw driver two weeks ago, which add support
 Michal> for reading MAC address from CPU and also I posted it to
 Michal> review.  You can find patch here :
 Michal> https://patchwork.kernel.org/patch/1966481/ I will create
 Michal> updated patch next week, depended on reactions. Can you try
 Michal> that patch? I'll be glad to hear your opinion.

Thanks, I missed that patch. Functionality wise the patches do the same,
but I must say I find my patch cleaner, as it doesn't involve any new dt
bindings or access to the am33xx specific control module registers from
the cpsw driver.

The way I've handled it is similar to how it is done on atleast one
other arm subarchicture, see
arch/arm/mach-mxs/mach-mxs.c::update_fec_mac_prop()

-- 
Bye, Peter Korsgaard

[PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

[Tony Lindgren]

* Peter Korsgaard <jacmet@sunsite.dk> [130117 08:46]:
> >>>>> "Michal" == Michal Bachraty <michal.bachraty@gmail.com> writes:
> 
> Hi Michael,
> 
>  Michal> I made changes to cpsw driver two weeks ago, which add support
>  Michal> for reading MAC address from CPU and also I posted it to
>  Michal> review.  You can find patch here :
>  Michal> https://patchwork.kernel.org/patch/1966481/ I will create
>  Michal> updated patch next week, depended on reactions. Can you try
>  Michal> that patch? I'll be glad to hear your opinion.
> 
> Thanks, I missed that patch. Functionality wise the patches do the same,
> but I must say I find my patch cleaner, as it doesn't involve any new dt
> bindings or access to the am33xx specific control module registers from
> the cpsw driver.
> 
> The way I've handled it is similar to how it is done on atleast one
> other arm subarchicture, see
> arch/arm/mach-mxs/mach-mxs.c::update_fec_mac_prop()

Cool this seems like the cleanest way to deal with it so far. Can
you please resend with also linux-net and DT list Cc:d too?

Also the arch_initcall should be omap_arch_initcall in linux next
for consistency if we ever have SoC specific sections for those.

Regards,

Tony

[PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

[Peter Korsgaard]

>>>>> "Tony" == Tony Lindgren <tony@atomide.com> writes:

Hi,

 >> The way I've handled it is similar to how it is done on atleast one
 >> other arm subarchicture, see
 >> arch/arm/mach-mxs/mach-mxs.c::update_fec_mac_prop()

 Tony> Cool this seems like the cleanest way to deal with it so far. Can
 Tony> you please resend with also linux-net and DT list Cc:d too?

 Tony> Also the arch_initcall should be omap_arch_initcall in linux next
 Tony> for consistency if we ever have SoC specific sections for those.

Sure, resent with the initcall change and netdev/devicetree-discuss added.

-- 
Bye, Peter Korsgaard

[PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

[Michal Bachraty]

On Thu, Jan 17, 2013 at 11:19 PM, Peter Korsgaard <jacmet@sunsite.dk> wrote:

> >>>>> "Tony" == Tony Lindgren <tony@atomide.com> writes:
>
> Hi,
>
>  >> The way I've handled it is similar to how it is done on atleast one
>  >> other arm subarchicture, see
>  >> arch/arm/mach-mxs/mach-mxs.c::update_fec_mac_prop()
>
>  Tony> Cool this seems like the cleanest way to deal with it so far. Can
>  Tony> you please resend with also linux-net and DT list Cc:d too?
>
>  Tony> Also the arch_initcall should be omap_arch_initcall in linux next
>  Tony> for consistency if we ever have SoC specific sections for those.
>
> Sure, resent with the initcall change and netdev/devicetree-discuss added.
>
> --
> Bye, Peter Korsgaard
>

Thanks,
I added DT option mac-address-source because there is still possiblility to
have mac address set by the u-boot in the future. Beaglebone have special
eeprom on board, were you can have stored user MAC and u-boot can read
eeprom
data. Maybe some users will want this feature.  Also in cpsw dt binding
documentation, there is mention  /* Filled in by U-Boot */.  For that
purpose,
code I proposed can easily deal with any driver exteds.

Reading CPU mac address registers with (my approach) or without (your
approach) DT should be more discussed. Also your way seems to be fine.

Regards
Michal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130118/6d8983db/attachment-0001.html>