From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id
Date: Fri, 18 Jan 2013 09:51:41 +0800 [thread overview]
Message-ID: <20130118015139.GA17155@nchen-desktop> (raw)
In-Reply-To: <CAOMZO5DNVMAG3btGR7DeukgWaEaPe2zqm=EKAHQ5ovawq+BiWw@mail.gmail.com>
On Thu, Jan 17, 2013 at 12:43:23PM -0200, Fabio Estevam wrote:
> On Thu, Jan 17, 2013 at 9:25 AM, Lothar Wa?mann <LW@karo-electronics.de> wrote:
>
> > The equivalent of !cpu_is_mx51() would be
> > strcmp(pdev->id_entry->name, "imx-udc-mx51") (without the '!') meaning
> > id_entry->name is different from "imx-udc-mx51".
Thanks, Lothar and Fabio, I will change, and send v7.
>
> Yes, agree.
>
> strcmp(pdev->id_entry->name, "imx-udc-mx51") is also better than
> !strcmp(pdev->id_entry->name, "imx-udc-mx27"))
We just think this feature only belongs to imx-udc-mx27 type udc
>
> because in the case of another soc entry gets added, let's say
> "imx-udc-mxyy" then
>
> !strcmp(pdev->id_entry->name, "imx-udc-mx27")) will not correspond to
> !cpu_is_mx51() anymore.
>
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2013-01-18 1:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 10:01 [PATCH v6 0/3] *** SUBJECT HERE *** Peter Chen
2013-01-17 10:01 ` [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id Peter Chen
2013-01-17 11:13 ` Fabio Estevam
2013-01-17 11:25 ` Lothar Waßmann
2013-01-17 14:43 ` Fabio Estevam
2013-01-18 1:51 ` Peter Chen [this message]
2013-01-17 10:01 ` [PATCH v6 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap Peter Chen
2013-01-17 10:01 ` [PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2013-01-17 10:03 [PATCH v6 0/3] Fix the Build error for fsl_mxc_udc.c Peter Chen
2013-01-17 10:03 ` [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118015139.GA17155@nchen-desktop \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).