From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [[PATCH v2]] OMAP: omap4-panda: add WiLink shared transport power functions
Date: Fri, 18 Jan 2013 09:36:35 -0800 [thread overview]
Message-ID: <20130118173635.GE15361@atomide.com> (raw)
In-Reply-To: <1358499533.6252.80.camel@cumari.coelho.fi>
* Luciano Coelho <coelho@ti.com> [130118 01:03]:
> On Thu, 2013-01-17 at 15:16 -0800, Tony Lindgren wrote:
> > * Luciano Coelho <coelho@ti.com> [130117 10:04]:
> > > But this patch is pretty small and simple, so why not include it to at
> > > least fix the breakage in 3.7 and 3.8? Whether you take it or not now
> > > won't make any difference in the 5k LOC in these kernel versions.
> >
> > Well we are planning to drop the non-DT support for omap4 as soon as it's
> > usable with DT. For omap4 we are only carrying SDP and panda support to
> > make this transition easier. The only bindings missing AFAIK are wl12xx and
> > USB.
>
> In my view this is a regression and it should be fixed with as simple a
> patch as possible. The alternative to my solution is to revert the
> patch that removed the enable/disable from the ti-st driver *and* fix
> u-boot, because if it doesn't mux the UART2 pins properly (and it
> doesn't) the shared transport still won't work.
Fixing the muxing here makes sense naturally as we cannot do that in the driver
until we've flipped things over to use DT.
But I don't think we should fix the driver regression by adding more platform
callbacks as we are getting rid of them anyways.
> > If we add this, then it implies we're somehow supporting it, which is not
> > the way to go IMHO as we need to get rid of these platform callbacks instead.
>
> It's a regression fix, not a new feature. I also think these callbacks
> are silly, but it's the quickest solution I found for 3.7 and 3.8.
Right, so how about let's fix the regression in the driver, and add the
muxing to platform init code?
> > What's your estimate of having minimal wl12xx WLAN DT binding available?
>
> To tell you the truth, I haven't even started looking into DT for wl12xx
> myself. So I have no idea when it will be ready. Benoit has been
> looking into it, but I don't know how far he is.
If it's going to take long we should just init the platform data for
it temporarily even in the DT boot case until the binding is available.
Regards,
Tony
next prev parent reply other threads:[~2013-01-18 17:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 21:45 [[PATCH v2]] OMAP: omap4-panda: add WiLink shared transport power functions Luciano Coelho
2013-01-17 9:30 ` Peter Ujfalusi
2013-01-17 9:34 ` Felipe Balbi
2013-01-17 9:55 ` Peter Ujfalusi
2013-01-17 10:05 ` Felipe Balbi
2013-01-17 10:09 ` Felipe Balbi
2013-01-17 10:35 ` Luciano Coelho
2013-01-17 10:40 ` Peter Ujfalusi
2013-01-17 17:31 ` Tony Lindgren
2013-01-17 17:57 ` Luciano Coelho
2013-01-17 23:16 ` Tony Lindgren
2013-01-18 8:58 ` Luciano Coelho
2013-01-18 17:36 ` Tony Lindgren [this message]
2013-01-18 17:54 ` Felipe Balbi
2013-01-18 18:05 ` Tony Lindgren
2013-01-18 19:08 ` Luciano Coelho
2013-01-18 19:22 ` Tony Lindgren
2013-01-18 10:11 ` Peter Ujfalusi
2013-01-18 17:49 ` Tony Lindgren
2013-01-23 8:55 ` Peter Ujfalusi
2013-01-17 9:35 ` Luciano Coelho
2013-01-17 9:59 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118173635.GE15361@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).