From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Compilation problem with drivers/staging/zsmalloc when !SMP on ARM
Date: Fri, 18 Jan 2013 21:08:59 +0000 [thread overview]
Message-ID: <20130118210859.GH23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAKGA1b=ACTQHo9=B7EAG5nrFCO9u-J+sy7dXtYk3Rk6OUcW3cQ@mail.gmail.com>
On Fri, Jan 18, 2013 at 02:24:15PM -0600, Matt Sealey wrote:
> Hello all,
>
> I wonder if anyone can shed some light on this linking problem I have
> right now. If I configure my kernel without SMP support (it is a very
> lean config for i.MX51 with device tree support only) I hit this error
> on linking:
Yes, I looked at this, and I've decided that I will _not_ fix this export,
neither will I accept a patch to add an export.
As far as I can see, this code is buggy in a SMP environment. There's
apparantly no guarantee that:
1. the mapping will be created on a particular CPU.
2. the mapping will then be used only on this specific CPU.
3. no guarantee that another CPU won't speculatively prefetch from this
region.
4. when the mapping is torn down, no guarantee that it's the same CPU that
used the happing.
So, the use of the local TLB flush leaves all the other CPUs potentially
containing TLB entries for this mapping.
Finally, there is no TODO file for this driver, which I believe is a
requirement for anything to be in stable. So as far as I can see, it
should be deleted or a TODO file added. I'm not sure why Greg decided
to add it without a TODO file.
(If there was such a file, I'd have added the above to it. As it is,
I've just decided to disable the thing in my randconfig builds.)
next prev parent reply other threads:[~2013-01-18 21:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 20:24 Compilation problem with drivers/staging/zsmalloc when !SMP on ARM Matt Sealey
2013-01-18 21:08 ` Russell King - ARM Linux [this message]
2013-01-18 21:45 ` Greg Kroah-Hartman
2013-01-19 4:37 ` Konrad Rzeszutek Wilk
2013-01-21 15:24 ` Russell King - ARM Linux
2013-01-22 20:33 ` Konrad Rzeszutek Wilk
2013-01-19 1:11 ` Matt Sealey
2013-01-19 4:46 ` Konrad Rzeszutek Wilk
2013-01-21 5:55 ` Minchan Kim
2013-01-21 16:00 ` Matt Sealey
2013-01-22 15:48 ` Minchan Kim
2013-01-22 20:34 ` Konrad Rzeszutek Wilk
2013-01-21 16:20 ` Matt Sealey
2013-01-21 16:29 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118210859.GH23505@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).