From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 18 Jan 2013 13:11:22 -0800 Subject: [PATCH v8 5/5] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND In-Reply-To: References: <1355481404-27695-1-git-send-email-zonque@gmail.com> <1355481404-27695-6-git-send-email-zonque@gmail.com> <20130114180602.GV14149@atomide.com> <20130115180324.GZ14149@atomide.com> Message-ID: <20130118211121.GU14149@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Ezequiel Garcia [130118 11:43]: > Tony, > > On Tue, Jan 15, 2013 at 3:03 PM, Tony Lindgren wrote: > > * Daniel Mack [130114 15:30]: > >> On Jan 15, 2013 2:06 AM, "Tony Lindgren" wrote: > >> > > >> > * Ezequiel Garcia [121223 13:49]: > >> > > On Fri, Dec 14, 2012 at 7:36 AM, Daniel Mack wrote: > >> > > > + > >> > > > +Example for an AM33xx board: > >> > > > + > >> > > > + gpmc: gpmc at 50000000 { > >> > > > + compatible = "ti,am3352-gpmc"; > >> > > > + ti,hwmods = "gpmc"; > >> > > > + reg = <0x50000000 0x1000000>; > >> > > > + interrupts = <100>; > >> > > > + gpmc,num-cs = <8>; > >> > > > + gpmc,num-waitpins = <2>; > >> > > > + #address-cells = <2>; > >> > > > + #size-cells = <1>; > >> > > > + ranges = <0 0 0x08000000 0x2000>; /* CS0: NAND > >> */ > >> > > > + > >> > > > + nand at 0,0 { > >> > > > + reg = <0 0 0>; /* CS0, offset 0 */ > >> > > > >> > > I'm a bit confused by this: what are the other two values in "reg"? > >> > > I see you've only added a binding for CS. > >> > > > >> > > I've extended a bit on your work and added a binding to enable OneNAND > >> > > device on my IGEP board. > >> > > > >> > > I might send some patches in case anyone wants to give it a try. > >> > > >> > Daniel, should this be updated to just pass the CS? > >> > >> No, as Rob pointed out earlier in a thread about this topic, the 'ranges' > >> feature will help doing the math for the offset calculation eventually, so > >> we need to pass all three values. > > > > OK thanks. Applying this set into omap-for-v3.9/gpmc. > > > > Also sounds like Ezequiel needs to update his follow up patches accordingly. > > > > The patches for OneNAND that were posted on the ML apply cleanly > on top omap-for-v3.9/gpmc. > > What do you want me to update? Oh I though you need to update the binding for the reg for your patches based on the comments above? Regards, Tony