From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben@fluff.org (Ben Dooks) Date: Mon, 21 Jan 2013 13:56:26 +0000 Subject: [PATCH] ARM: plat-samsung: using vsnprintf instead of vsprintf for the limit buffer length 256 In-Reply-To: <50FD178E.9090105@asianux.com> References: <50FD178E.9090105@asianux.com> Message-ID: <20130121135626.GP1095@trinity.fluff.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 21, 2013 at 06:25:18PM +0800, Chen Gang wrote: > > the buff size is 256, so need use vsnprintf instead of vsprintf. > > Signed-off-by: Chen Gang > --- > arch/arm/plat-samsung/pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c > index 1507028..8d07b45 100644 > --- a/arch/arm/plat-samsung/pm.c > +++ b/arch/arm/plat-samsung/pm.c > @@ -51,7 +51,7 @@ void s3c_pm_dbg(const char *fmt, ...) > char buff[256]; > > va_start(va, fmt); > - vsprintf(buff, fmt, va); > + vsnprintf(buff, 256, fmt, va); How about: vsnprintf(buff, sizeof(buff), fmt, va); It means we do not end up assuming the size of 'buff' and will be correct if the code is changed to declare 'buff' to be a different size. -- Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear.