From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 09/15] gpio: pl061: set initcall level to module init
Date: Tue, 22 Jan 2013 10:41:07 +0000 [thread overview]
Message-ID: <20130122104107.GJ23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CACRpkdY4MHLjs1Lnj+8Ts6oZOjG14pDssCQ09PX-a_5nGRs1sg@mail.gmail.com>
On Tue, Jan 22, 2013 at 10:42:11AM +0100, Linus Walleij wrote:
> On Mon, Jan 21, 2013 at 5:24 PM, Pawel Moll <pawel.moll@arm.com> wrote:
>
> > Hm. Doesn't this make the MMCI probing depending on the module_init
> > order? As in: wouldn't it make the mmci probe completely fail (not even
> > defer it) if it was called before the pl061? In that case even your,
> > Linus, hack with inverting the CD status wouldn't work...
>
> According to Haojian it works, but for sure the MMCI driver *should*
> (on the eternal list of SHOULDDO) bail out and return any
Rather than talking about what should and should not, why not look at
the code - it only takes a few moments to check what the behaviour
would be. And it is correct - errors are correctly propagated out of
the probe function.
That's hardly surprising given who's supposed to be the maintainer of
that driver.
next prev parent reply other threads:[~2013-01-22 10:41 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 7:31 [PATCH v7 0/15] support pinconf in pinctrl single driver Haojian Zhuang
2013-01-18 7:31 ` [PATCH v7 01/15] Revert "pinctrl: single: support gpio request and free" Haojian Zhuang
2013-01-21 16:56 ` Tony Lindgren
2013-01-22 12:49 ` Linus Walleij
2013-01-18 7:31 ` [PATCH v7 02/15] pinctrl: core: get devname from pinctrl_dev Haojian Zhuang
2013-01-21 14:15 ` Linus Walleij
2013-01-18 7:31 ` [PATCH v7 03/15] gpio: use pinctrl device name for add range Haojian Zhuang
2013-01-21 14:20 ` Linus Walleij
2013-01-21 15:24 ` Haojian Zhuang
2013-01-18 7:31 ` [PATCH v7 04/15] gpio: set gpio range cells property as 3 Haojian Zhuang
2013-01-21 14:23 ` Linus Walleij
2013-01-18 7:31 ` [PATCH v7 05/15] gpio: fix wrong checking condition for gpio range Haojian Zhuang
2013-01-18 12:18 ` Sergei Shtylyov
2013-01-18 15:02 ` Haojian Zhuang
2013-01-18 12:21 ` Sergei Shtylyov
2013-01-18 7:31 ` [PATCH v7 06/15] gpio: find gpio base by ascend order Haojian Zhuang
2013-01-21 14:24 ` Linus Walleij
2013-02-09 13:45 ` Grant Likely
2013-02-09 17:15 ` Haojian Zhuang
2013-01-18 7:31 ` [PATCH v7 07/15] gpio: pl061: allocate irq dynamically Haojian Zhuang
2013-01-18 7:31 ` [PATCH v7 08/15] gpio: pl061: bind pinctrl by gpio request Haojian Zhuang
2013-01-21 14:37 ` Linus Walleij
2013-01-21 15:45 ` Haojian Zhuang
2013-01-22 9:10 ` Linus Walleij
2013-01-22 9:55 ` Haojian Zhuang
2013-01-22 10:10 ` Linus Walleij
2013-01-18 7:31 ` [PATCH v7 09/15] gpio: pl061: set initcall level to module init Haojian Zhuang
2013-01-21 14:41 ` Linus Walleij
2013-01-21 16:24 ` Pawel Moll
2013-01-21 20:20 ` Dinh Nguyen
2013-01-22 9:44 ` Linus Walleij
2013-01-22 15:47 ` Dinh Nguyen
2013-01-21 23:33 ` Haojian Zhuang
2013-01-22 10:21 ` Pawel Moll
2013-01-22 9:42 ` Linus Walleij
2013-01-22 10:13 ` Pawel Moll
2013-01-22 10:41 ` Russell King - ARM Linux [this message]
2013-01-22 12:55 ` Linus Walleij
2013-01-22 9:45 ` Linus Walleij
2013-01-18 7:31 ` [PATCH v7 10/15] pinctrl: single: create new gpio function range Haojian Zhuang
2013-01-18 7:31 ` [PATCH v7 11/15] pinctrl: generic: add slew rate config parameter Haojian Zhuang
2013-01-21 14:44 ` Linus Walleij
2013-01-18 7:31 ` [PATCH v7 12/15] pinctrl: generic: dump pin configuration Haojian Zhuang
2013-01-18 7:31 ` [PATCH v7 13/15] pinctrl: single: set function mask as optional Haojian Zhuang
2013-01-18 7:31 ` [PATCH v7 14/15] pinctrl: single: support generic pinconf Haojian Zhuang
2013-01-21 17:14 ` Tony Lindgren
2013-01-22 5:54 ` Haojian Zhuang
2013-01-22 18:55 ` Tony Lindgren
2013-01-18 7:31 ` [PATCH v7 15/15] ARM: hs: enable hi4511 with device tree Haojian Zhuang
2013-02-09 13:41 ` [PATCH v7 0/15] support pinconf in pinctrl single driver Grant Likely
2013-02-09 17:17 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122104107.GJ23505@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).