From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Deduplicate exit code in clk_set_rate
Date: Tue, 22 Jan 2013 08:38:25 -0800 [thread overview]
Message-ID: <20130122163825.24671.24785@quantum> (raw)
In-Reply-To: <1358525259-7979-1-git-send-email-novroy@riseup.net>
Quoting Nestor Ovroy (2013-01-18 08:07:39)
> On non-out case 'return ret;' is equivalent to 'return 0;' as the ret
> variable is initialized at 0 and never changed.
>
> Signed-off-by: Nestor Ovroy <novroy@riseup.net>
Nestor,
Thanks for the fix. Taken into clk-next.
Regards,
Mike
> ---
> drivers/clk/clk.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 251e45d..0e21d7a 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -948,13 +948,10 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
> }
>
> /* change the rates */
> clk_change_rate(top);
>
> - mutex_unlock(&prepare_lock);
> -
> - return 0;
> out:
> mutex_unlock(&prepare_lock);
>
> return ret;
> }
> --
> 1.7.10.4
prev parent reply other threads:[~2013-01-22 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 16:07 [PATCH] clk: Deduplicate exit code in clk_set_rate Nestor Ovroy
2013-01-22 16:38 ` Mike Turquette [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122163825.24671.24785@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).