From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: plat-orion: fix printing of "MPP config unavailable on this hardware"
Date: Wed, 23 Jan 2013 09:38:55 -0500 [thread overview]
Message-ID: <20130123143855.GP1758@titan.lakedaemon.net> (raw)
In-Reply-To: <50FFF489.5070506@keymile.com>
On Wed, Jan 23, 2013 at 03:32:41PM +0100, Gerlando Falauto wrote:
> On 01/23/2013 03:25 PM, Jason Cooper wrote:
> >On Wed, Jan 23, 2013 at 02:50:59PM +0100, Gerlando Falauto wrote:
> >>Commit 3cff484d4b264ff467a3b45c544cbbbab69f0bf8
> >>ARM: dove: Consolidate mpp code with platform mpp.
> >>
> >>refactored printing of the kernel warning
> >>"orion_mpp_conf: requested MPP%u config unavailable on this hardware\n"
> >>which is not to be printed in case of variant_mask = 0 (unknown variant).
> >>This check should be performed using a logical AND (&&) as opposed
> >>to a bitwise AND (&).
> >>Otherwise, test would fail (and message would be printed) if variant_mask != 1
>
> Whooops, what I meant was "and message would NOT be printed"... sorry. :-(
> Shouldn't really matter anyway.
fixed in mvebu/fixes.
thx,
Jason.
prev parent reply other threads:[~2013-01-23 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 13:50 [PATCH] arm: plat-orion: fix printing of "MPP config unavailable on this hardware" Gerlando Falauto
2013-01-23 14:08 ` Andrew Lunn
2013-01-23 14:25 ` Jason Cooper
2013-01-23 14:32 ` Gerlando Falauto
2013-01-23 14:38 ` Jason Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123143855.GP1758@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox