Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] i2c: sirf: add support for new SiRFmarco SMP SoC
Date: Thu, 24 Jan 2013 08:27:36 +0100	[thread overview]
Message-ID: <20130124072736.GJ8364@nekote.pengutronix.de> (raw)
In-Reply-To: <1356489017-17737-2-git-send-email-Barry.Song@csr.com>

On Wed, Dec 26, 2012 at 10:30:17AM +0800, Barry Song wrote:
> From: Barry Song <Baohua.Song@csr.com>
> 
> the driver is also compatible with SiRFmarco except SiRFprimaII,
> so simply add "sirf,marco-i2c" to OF match table.
> 
> Signed-off-by: Barry Song <Baohua.Song@csr.com>

Why can't you use the existing compatible entry as a fallback like in:

	compatible = "sirf,marco-i2c", "sirf,prima2-i2c";
?

> ---
>  drivers/i2c/busses/i2c-sirf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c
> index 181d7c2..ed38b16 100644
> --- a/drivers/i2c/busses/i2c-sirf.c
> +++ b/drivers/i2c/busses/i2c-sirf.c
> @@ -439,6 +439,7 @@ static const struct dev_pm_ops i2c_sirfsoc_pm_ops = {
>  
>  static const struct of_device_id sirfsoc_i2c_of_match[] __devinitconst = {
>  	{ .compatible = "sirf,prima2-i2c", },
> +	{ .compatible = "sirf,marco-i2c", },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, sirfsoc_i2c_of_match);
> -- 

  reply	other threads:[~2013-01-24  7:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-26  2:30 [PATCH 1/2] i2c: sirf: register i2c_client from dt child-nodes in probe entry Barry Song
2012-12-26  2:30 ` [PATCH 2/2] i2c: sirf: add support for new SiRFmarco SMP SoC Barry Song
2013-01-24  7:27   ` Wolfram Sang [this message]
2013-01-24  7:38     ` Barry Song
2013-01-23  9:56 ` [PATCH 1/2] i2c: sirf: register i2c_client from dt child-nodes in probe entry Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124072736.GJ8364@nekote.pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox