linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] clk: vt8500: Use common of_clk_init() function
Date: Thu, 24 Jan 2013 11:15:34 -0800	[thread overview]
Message-ID: <20130124191534.10623.14882@quantum> (raw)
In-Reply-To: <1358543280.8280.2.camel@gitbox>

Quoting Tony Prisk (2013-01-18 13:08:00)
> On Fri, 2013-01-18 at 09:56 -0800, Mike Turquette wrote:
> > Quoting Prashant Gaikwad (2013-01-03 23:00:56)
> > > Use common of_clk_init() function for clock initialization.
> > > 
> > > Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
> > 
> > Tony,
> > 
> > Can I get a Tested-by from you before I take this in?
> > 
> Tested-by: Tony Prisk <linux@prisktech.co.nz>
> 
> FYI: This will need another patch to complete as we added another set of
> clocks to this clk-vt8500.c for 3.9.
> 

Tony, is the following patch correct?


>From 5b6e0adb69674c684c33503f50010644b049029c Mon Sep 17 00:00:00 2001
From: Prashant Gaikwad <pgaikwad@nvidia.com>
Date: Fri, 4 Jan 2013 12:30:56 +0530
Subject: [PATCH] clk: vt8500: Use common of_clk_init() function

Use common of_clk_init() function for clock initialization.

Signed-off-by: Prashant Gaikwad <pgaikwad@nvidia.com>
Tested-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
[mturquette at linaro.org: added entry for wm8750-pll-clock]

Signed-off-by: Mike Turquette <mturquette@linaro.org>
---
 drivers/clk/clk-vt8500.c |   17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
index 2515d4f..b5538bb 100644
--- a/drivers/clk/clk-vt8500.c
+++ b/drivers/clk/clk-vt8500.c
@@ -291,7 +291,7 @@ static __init void vtwm_device_clk_init(struct device_node *node)
 	rc = of_clk_add_provider(node, of_clk_src_simple_get, clk);
 	clk_register_clkdev(clk, clk_name, NULL);
 }
-
+CLK_OF_DECLARE(vt8500_device, "via,vt8500-device-clock", vtwm_device_clk_init);
 
 /* PLL clock related functions */
 
@@ -612,26 +612,19 @@ static void __init vt8500_pll_init(struct device_node *node)
 {
 	vtwm_pll_clk_init(node, PLL_TYPE_VT8500);
 }
+CLK_OF_DECLARE(vt8500_pll, "via,vt8500-pll-clock", vt8500_pll_init);
 
 static void __init wm8650_pll_init(struct device_node *node)
 {
 	vtwm_pll_clk_init(node, PLL_TYPE_WM8650);
 }
+CLK_OF_DECLARE(wm8650_pll, "wm,wm8650-pll-clock", wm8650_pll_init);
 
 static void __init wm8750_pll_init(struct device_node *node)
 {
 	vtwm_pll_clk_init(node, PLL_TYPE_WM8750);
 }
-
-static const __initconst struct of_device_id clk_match[] = {
-	{ .compatible = "fixed-clock", .data = of_fixed_clk_setup, },
-	{ .compatible = "via,vt8500-pll-clock", .data = vt8500_pll_init, },
-	{ .compatible = "wm,wm8650-pll-clock", .data = wm8650_pll_init, },
-	{ .compatible = "wm,wm8750-pll-clock", .data = wm8750_pll_init, },
-	{ .compatible = "via,vt8500-device-clock",
-					.data = vtwm_device_clk_init, },
-	{ /* sentinel */ }
-};
+CLK_OF_DECLARE(wm8750_pll, "wm,wm8750-pll-clock", wm8750_pll_init);
 
 void __init vtwm_clk_init(void __iomem *base)
 {
@@ -640,5 +633,5 @@ void __init vtwm_clk_init(void __iomem *base)
 
 	pmc_base = base;
 
-	of_clk_init(clk_match);
+	of_clk_init(NULL);
 }
-- 
1.7.10.4

  reply	other threads:[~2013-01-24 19:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-04  7:00 [PATCH 1/7] clk: add common of_clk_init() function Prashant Gaikwad
2013-01-04  7:00 ` [PATCH 2/7] clk: tegra: Use " Prashant Gaikwad
2013-01-04 16:30   ` Stephen Warren
2013-01-05  2:44     ` Prashant Gaikwad
2013-01-24 19:20       ` Mike Turquette
2013-01-24 19:32         ` Stephen Warren
     [not found]           ` <20130125005729.10623.61165@quantum>
2013-01-25  4:44             ` Stephen Warren
2013-02-01  4:49               ` Prashant Gaikwad
2013-02-01 22:53                 ` Mike Turquette
2013-01-04  7:00 ` [PATCH 3/7] clk: sunxi: " Prashant Gaikwad
2013-01-04  7:00 ` [PATCH 4/7] clk: highbank: " Prashant Gaikwad
2013-01-18 17:55   ` Mike Turquette
2013-01-04  7:00 ` [PATCH 5/7] clk: vt8500: " Prashant Gaikwad
2013-01-18 17:56   ` Mike Turquette
2013-01-18 21:08     ` Tony Prisk
2013-01-24 19:15       ` Mike Turquette [this message]
2013-01-25  4:01         ` Tony Prisk
2013-01-04  7:00 ` [PATCH 6/7] clk: zynq: " Prashant Gaikwad
2013-01-04  7:00 ` [PATCH 7/7] clk: vexpress: " Prashant Gaikwad
2013-01-18 17:58   ` Mike Turquette
2013-01-21 16:03     ` Pawel Moll
2013-01-22  9:13     ` Linus Walleij
2013-01-23 10:54   ` Pawel Moll
2013-01-10 19:53 ` [PATCH 1/7] clk: add " Josh Cartwright
2013-01-11  5:01   ` Prashant Gaikwad
2013-01-13  8:57 ` Maxime Ripard
2013-01-24 17:47 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124191534.10623.14882@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).