From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL v2] arm-soc: Xilinx zynq timer changes for v3.9
Date: Sun, 27 Jan 2013 22:13:50 -0800 [thread overview]
Message-ID: <20130128061350.GC25723@quad.lixom.net> (raw)
In-Reply-To: <CAHTX3dLSp5_OZmuvU18s=A19e7F1Jq7tgTjayV8qFDJ1FTJztA@mail.gmail.com>
On Fri, Jan 25, 2013 at 04:48:43PM +0100, Michal Simek wrote:
> Hi Arnd and Olof,
>
> can you please look at this pull request?
Hi,
Sorry for the delay. I was out sick part of last week and dealing with
backlog when I got back on my feet. Doing a sweep of pull requests now.
Two comments.
1. mach-pxa/time.c conflict resolution doesn't seem right -- you for some
reason deleted the suspend/resume struct members from the
clock_event_device.
2. Below:
> > Soren Brinkmann (7):
> > arm: zynq: timer: Replace PSS through PS
This is pure churn. :( We can't keep renaming things in the kernel just
because some document writer decides to change a term, we tend to stick
to what's already there. As long as it's not completely misleading, at least.
I' shortly push a new "depends/cleanup" branch to arm-soc. It essentially
contains the next/cleanup contents that you merged together yourself,
but as a branch that you can just pull in. Since others might need to
do the same, providing the branch from us just makes sense.
So, can you please rebase on top of that and send a fresh pull request? If
you really want the PSS->PS rename included I'll give you a first-time
pass for it but please keep it in mind for the future.
Thanks!
-Olof
next prev parent reply other threads:[~2013-01-28 6:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 13:08 [GIT PULL v2] arm-soc: Xilinx zynq timer changes for v3.9 Michal Simek
2013-01-25 15:48 ` Michal Simek
2013-01-28 6:13 ` Olof Johansson [this message]
2013-01-28 12:34 ` Michal Simek
2013-01-30 2:06 ` Olof Johansson
2013-01-28 12:53 ` [GIT PULL v3] " Michal Simek
2013-01-30 2:11 ` Olof Johansson
2013-01-30 9:13 ` Michal Simek
2013-01-30 2:29 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128061350.GC25723@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox