linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs
Date: Mon, 28 Jan 2013 09:02:40 +0000	[thread overview]
Message-ID: <20130128090240.GA7754@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <016c01cdfb30$64f80430$2ee80c90$@samsung.com>

On Fri, Jan 25, 2013 at 07:15:48PM +0000, Kukjin Kim wrote:
> Tomasz Figa wrote:
> 
> [...]
> 
> > > Well, the number of CPU types does not grow rapidly.  It will be much
> > > less than one per SoC -- so keeping the list up to date shouldn't be
> > > that much effort.
> > >
> > > For ARM1176JZF-S, it could make sense for the comatible list to be
> > >
> > > 	"arm,arm1176jzf-s", "arm,arm1176"
> > >
> > > ...since the differences between 1176 variants are software probeable
> > > (i.e., whether there is an FPU or not).  AFAIK the J, Z apply to all
> > > ARM1176, and the -S (synthesisable RTL) is nothing to do with software.
> > > The kernel probably only really needs to know "arm,arm1176".
> > 
> > OK. So the conclusion is that I should change the cpus node to following:
> > 
> >        cpus {
> >                cpu {
> 
> cpu at 0 { ?

As the CPU has no MPIDR, and thus doesn't have a reg property, there's no reason
to have a unit address. Just "cpu" should be fine.

> 
> >                        compatible = "arm,arm1176jzf-s", "arm,arm1176";
> >                };
> >        };
> > 
> > Am I right?
> > 
> I think so :-)
> 
> - Kukjin
> 

As Dave pointed out, the "jzf-s" portion might be superfluous. It's worth
having the "arm,arm1176", though.

Thanks,
Mark.

  reply	other threads:[~2013-01-28  9:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13  1:10 [PATCH 0/6] Initial Device Tree support for S3C64xx Tomasz Figa
2013-01-13  1:10 ` [PATCH 1/6] ARM: common: vic: Parse interrupt and resume masks from device tree Tomasz Figa
2013-01-14  1:08   ` Rob Herring
2013-01-14 10:44     ` Tomasz Figa
2013-01-13  1:10 ` [PATCH 2/6] ARM: common: vic: Fix invalid first IRQ number in OF-based registration Tomasz Figa
2013-01-13  1:10 ` [PATCH 3/6] ARM: s3c64xx: Add support for OF-based VIC initialization Tomasz Figa
2013-01-13  1:10 ` [PATCH 4/6] ARM: s3c64xx: Add board file for boot using Device Tree Tomasz Figa
2013-01-13  1:10 ` [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs Tomasz Figa
2013-01-14 14:48   ` Mark Rutland
2013-01-14 15:05     ` Lorenzo Pieralisi
2013-01-16 10:59       ` Dave Martin
2013-01-25 19:08         ` Tomasz Figa
2013-01-25 19:15           ` Kukjin Kim
2013-01-28  9:02             ` Mark Rutland [this message]
2013-01-28 13:04               ` Dave Martin
2013-01-13  1:10 ` [PATCH 6/6] ARM: dts: Add dts file for S3C6410-based Mini6410 board Tomasz Figa
2013-01-25 19:09 ` [PATCH 0/6] Initial Device Tree support for S3C64xx Tomasz Figa
2013-01-25 19:25   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130128090240.GA7754@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).