From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type
Date: Tue, 29 Jan 2013 14:53:36 +0100 [thread overview]
Message-ID: <20130129135336.GA3323@pengutronix.de> (raw)
In-Reply-To: <5107D253.5030400@ti.com>
> >+ err = of_property_read_string(np, "phy_type", &phy_type);
> >+ if (err < 0)
> >+ return USBPHY_INTERFACE_MODE_NA;
>
> Why don't we use a u32 property type for the *phy-type*? IMHO we
> should use string property only when the property should be
> absolutely unambiguous (e.g., compatible property should be string).
If we would use u32-numbers in the compatible entry, this would also be
unambiguous, no? 0xd00dfeed would be the at24-driver. Pretty specific.
I don't mind having readable devicetrees. And we have it for ethernet
phys already with strings, so it would be consistent.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130129/0b5575ea/attachment.sig>
next prev parent reply other threads:[~2013-01-29 13:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 11:22 [PATCH, RFC] usb: add devicetree helpers for determining dr_mode and phy_type Sascha Hauer
2013-01-29 11:55 ` Alexander Shishkin
2013-01-30 2:06 ` [PATCH,RFC] " Peter Chen
2013-01-30 14:00 ` Sascha Hauer
2013-01-31 2:05 ` Peter Chen
2013-01-31 10:29 ` Sascha Hauer
2013-02-01 1:11 ` Peter Chen
2013-02-01 6:58 ` Sascha Hauer
2013-02-01 12:21 ` Peter Chen
2013-01-29 13:44 ` kishon
2013-01-29 13:53 ` Wolfram Sang [this message]
2013-01-29 14:10 ` kishon
2013-01-29 14:33 ` Felipe Balbi
2013-01-29 14:55 ` Wolfram Sang
2013-01-29 15:05 ` Marc Kleine-Budde
2013-01-30 19:33 ` Matt Sealey
2013-01-30 19:35 ` Matt Sealey
2013-01-29 17:10 ` Stephen Warren
2013-01-29 20:30 ` Sascha Hauer
2013-01-30 5:51 ` kishon
2013-01-30 10:11 ` Sascha Hauer
2013-01-30 10:31 ` kishon
2013-01-29 17:11 ` [PATCH, RFC] " Stephen Warren
2013-01-29 17:16 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129135336.GA3323@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).