linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pavel@denx.de (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv1 for soc 5/5] arm: socfpga: Add SMP support for actual socfpga harware
Date: Tue, 29 Jan 2013 19:43:41 +0100	[thread overview]
Message-ID: <20130129184340.GA1962@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1359075633-13502-6-git-send-email-dinguyen@altera.com>

Hi!

> index 9941caa..5b76dd4 100644
> --- a/arch/arm/mach-socfpga/core.h
> +++ b/arch/arm/mach-socfpga/core.h
> @@ -20,7 +20,7 @@
>  #ifndef __MACH_CORE_H
>  #define __MACH_CORE_H
>  
> -extern void secondary_startup(void);
> +extern void v7_secondary_startup(void);
>  extern void __iomem *socfpga_scu_base_addr;
>  

One more thing. v7_secondary_startup() may be too generic name for a
symbol. mach-imx already uses that.

Plus, mach-imx also has the useless #ifdef.

---

Remove useless #ifdef; headsmp.S is only compiled in CONFIG_SMP
configuration.

Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/arch/arm/mach-imx/headsmp.S b/arch/arm/mach-imx/headsmp.S
index 7e49deb..4c9ec06 100644
--- a/arch/arm/mach-imx/headsmp.S
+++ b/arch/arm/mach-imx/headsmp.S
@@ -64,12 +64,10 @@ ENTRY(v7_invalidate_l1)
 	mov	pc, lr
 ENDPROC(v7_invalidate_l1)
 
-#ifdef CONFIG_SMP
 ENTRY(v7_secondary_startup)
 	bl	v7_invalidate_l1
 	b	secondary_startup
 ENDPROC(v7_secondary_startup)
-#endif
 
 #ifdef CONFIG_PM
 /*


Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      parent reply	other threads:[~2013-01-29 18:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25  1:00 [PATCHv1 for soc 0/5] Enabling socfpga on hardware dinguyen at altera.com
2013-01-25  1:00 ` [PATCHv1 for soc 1/5] arm: socfpga: Add new device tree source for actual socfpga HW dinguyen at altera.com
2013-01-25 14:22   ` Pavel Machek
2013-01-25 16:18     ` Dinh Nguyen
2013-01-28  7:12   ` Olof Johansson
2013-01-25  1:00 ` [PATCHv1 for soc 2/5] arm: socfpga: Add clock entries to socfpga.dtsi dinguyen at altera.com
2013-01-28  7:13   ` Olof Johansson
2013-01-28 11:19     ` Pavel Machek
2013-01-25  1:00 ` [PATCHv1 for soc 3/5] arm: socfpga: Add entries to enable make dtbs socfpga dinguyen at altera.com
2013-01-25 15:13   ` Pavel Machek
2013-01-25 16:21     ` Dinh Nguyen
2013-01-25  1:00 ` [PATCHv1 for soc 4/5] arm: Add v7_invalidate_l1 to cache-v7.S dinguyen at altera.com
2013-01-25  4:15   ` Simon Horman
2013-01-25  4:35     ` Simon Horman
2013-01-25 16:18       ` Dinh Nguyen
2013-01-25  4:42   ` Stephen Warren
2013-01-28 10:45     ` Pavel Machek
2013-01-28 17:27       ` Stephen Warren
2013-01-28 17:35         ` Dinh Nguyen
2013-01-25  8:13   ` Santosh Shilimkar
2013-01-25 16:20     ` Dinh Nguyen
2013-01-25 17:47       ` Santosh Shilimkar
2013-01-25 15:49   ` Pavel Machek
2013-01-25 16:24     ` Dinh Nguyen
2013-01-25 18:05       ` Pavel Machek
2013-01-28 13:13       ` Shawn Guo
2013-01-25  1:00 ` [PATCHv1 for soc 5/5] arm: socfpga: Add SMP support for actual socfpga harware dinguyen at altera.com
2013-01-25 17:55   ` Pavel Machek
2013-01-25 21:02     ` Dinh Nguyen
2013-01-26 20:59       ` Pavel Machek
2013-01-28 19:31   ` Pavel Machek
2013-01-28 19:36   ` [RFC] socfpga: make function static Pavel Machek
2013-01-29 18:43   ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130129184340.GA1962@amd.pavel.ucw.cz \
    --to=pavel@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).