From: richard.genoud@gmail.com (Richard GENOUD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:boot: support the command with COMMAND_LINE_SIZE - 1 useful chars
Date: Wed, 30 Jan 2013 16:40:52 +0100 [thread overview]
Message-ID: <20130130154051.GA18119@lnx-rg.pr> (raw)
In-Reply-To: <510912D5.5030505@asianux.com>
On [mer., 30.01.2013 20:32:21], Chen Gang wrote:
>
> originally, not support the command with COMMAND_LINE_SIZE - 1 useful chars.
> but in fact, we can support it:
>
You're right.
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/boot/compressed/atags_to_fdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/compressed/atags_to_fdt.c b/arch/arm/boot/compressed/atags_to_fdt.c
> index aabc02a..ed23ec2 100644
> --- a/arch/arm/boot/compressed/atags_to_fdt.c
> +++ b/arch/arm/boot/compressed/atags_to_fdt.c
> @@ -63,7 +63,7 @@ static void merge_fdt_bootargs(void *fdt, const char *fdt_cmdline)
> /* copy the fdt command line into the buffer */
> fdt_bootargs = getprop(fdt, "/chosen", "bootargs", &len);
> if (fdt_bootargs)
> - if (len < COMMAND_LINE_SIZE) {
> + if (len <= COMMAND_LINE_SIZE) {
> memcpy(ptr, fdt_bootargs, len);
> /* len is the length of the string
> * including the NULL terminator */
> @@ -73,7 +73,7 @@ static void merge_fdt_bootargs(void *fdt, const char *fdt_cmdline)
> /* and append the ATAG_CMDLINE */
> if (fdt_cmdline) {
> len = strlen(fdt_cmdline);
> - if (ptr - cmdline + len + 2 < COMMAND_LINE_SIZE) {
> + if (ptr - cmdline + len + 2 <= COMMAND_LINE_SIZE) {
> *ptr++ = ' ';
> memcpy(ptr, fdt_cmdline, len);
> ptr += len;
> --
> 1.7.10.4
next prev parent reply other threads:[~2013-01-30 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 12:32 [PATCH] ARM:boot: support the command with COMMAND_LINE_SIZE - 1 useful chars Chen Gang
2013-01-30 15:40 ` Richard GENOUD [this message]
2013-02-01 1:13 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130154051.GA18119@lnx-rg.pr \
--to=richard.genoud@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox