From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Thu, 31 Jan 2013 19:11:19 -0500 Subject: [PATCH v2 1/2] ARM: kirkwood: Ensure that kirkwood_ge0[01]_init() finds its clock In-Reply-To: <510AF502.5060306@gmail.com> References: <20130129004824.GB7717@titan.lakedaemon.net> <20130129194243.GA30831@schnuecks.de> <51082C4E.5050903@gmail.com> <20130130000341.GA10600@schnuecks.de> <51086E86.8040705@gmail.com> <20130130083044.GA25688@schnuecks.de> <5108F300.7000705@gmail.com> <20130130230100.GV7717@titan.lakedaemon.net> <20130131224457.GB17976@schnuecks.de> <510AF502.5060306@gmail.com> Message-ID: <20130201001119.GL7717@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 31, 2013 at 11:49:38PM +0100, Sebastian Hesselbarth wrote: > On 01/31/2013 11:44 PM, Simon Baatz wrote: > >Hi Jason, Sebastian, > > > >On Wed, Jan 30, 2013 at 06:01:00PM -0500, Jason Cooper wrote: > >> > >>wrt to runit gating, the only case we are not covering is if of_serial > >>is a module (and so is everything else using the runit clk). That's > >>*really* rare. If someone embarks down that path, they get the > >>responsibility of not writing to all the deactivated registers. ;-) > > > >With the serial driver now enabling runit it is really rare, but > >where is your enthusiasm to get to the bottom of it? At least we > >have indications that there really is something in "..." (my box > >stops somewhere when no driver enables runit) > > I think watchdog could be an issue, Jason had it disabled and > he was able to run it, right? I don't have a strong opinion on that, > but I'd disable every clock you can - OTOH runit will be enabled > anyway if you choose to have serial. I got the list of modules be searching kirkwood.dtsi for '&gate_clk 7'. the watchdog made the list. Once I can get a proper test environment setup, my first goal is to show runit gated from a command prompt. The second goal is to use it in a *really* locked down / low power firewall gateway. There is no timeline for goal number two. ;-) > >Sebastian, are you still interested in the .flags stuff from the > >runit patch or do you see no need now since "ddr" is the only > >exception anyway? > > I don't expect to use it on Dove but it should be good to have for > Kirkwood and maybe Armada XP/370 too. You prepare a patch? I'm thinking we probably don't need it atm. thx, Jason.